🤖 Merge PR DefinitelyTyped#74600 [@types/worker-plugin]: update types by @arturovt

Author: arturovt

types/worker-plugin/index.d.ts

@@ -2,30 +2,66 @@ import webpack = require("webpack");
 
 export = WorkerPlugin;
 
-declare class WorkerPlugin extends webpack.Plugin {
+declare class WorkerPlugin implements webpack.WebpackPluginInstance {
     constructor(options?: WorkerPlugin.Options);
+    apply(compiler: webpack.Compiler): void;
 }
 
 declare namespace WorkerPlugin {
     interface Options {
+        /**
+         * Controls the name of the generated worker chunk.
+         * The name is used to generate a URL according to `output.chunkFilename`.
+         */
         filename?: string | undefined;
+
+        /**
+         * Controls the chunk filename of secondary chunks generated by the worker bundle.
+         * Defaults to the parent compiler's `output.chunkFilename`.
+         */
         chunkFilename?: string | undefined;
+
+        /**
+         * Configures the value of `output.globalObject` for WorkerPlugin's internal Webpack compiler.
+         * Set to `false` to disable the warning when `output.globalObject` is set to `"window"`.
+         * Defaults to `"self"`, which is required for HMR to work correctly in workers.
+         */
         globalObject?: false | string | undefined;
-        plugins?: Array<string | webpack.Plugin> | undefined;
+
         /**
-         * If set to `true`, this option enables the bundling of [SharedWorker](https://developer.mozilla.org/en-US/docs/Web/API/SharedWorker)
+         * List of Webpack plugins to apply to the worker's child compiler.
+         * By default, no plugins from the parent compiler are applied to avoid running things
+         * like `html-webpack-plugin` twice. Pass a plugin name string to copy it from the
+         * parent compiler's configuration, or pass a plugin instance to apply it only to worker code.
+         */
+        plugins?: Array<string | webpack.WebpackPluginInstance> | undefined;
+
+        /**
+         * If set to `true`, enables bundling of
+         * [`SharedWorker`](https://developer.mozilla.org/en-US/docs/Web/API/SharedWorker).
+         * @default false
          */
         sharedWorker?: boolean | undefined;
+
         /**
-         * If set to `false`, this option disables the bundling of [Worker].
-         * Intended to be used with `{ sharedWorker: true }` to allow bundling of [SharedWorker] only without also bundling [Worker].
+         * If set to `false`, disables bundling of `Worker`.
+         * Intended to be used with `{ sharedWorker: true }` to bundle `SharedWorker` only.
+         * @default true
          */
         worker?: boolean | undefined;
+
+        /**
+         * If set to `true`, retains `{ type: 'module' }` in the bundled output instead of
+         * removing it. By default, WorkerPlugin removes the `type` option to compile
+         * Module Workers to Classic Workers, which are supported in all browsers.
+         * @default false
+         */
         preserveTypeModule?: boolean | undefined;
+
         /**
-         * Normally, WorkerPlugin will transform `new Worker('./a.js', { type: 'module' })`
-         * to completely remove the `type` option, outputting something like `new Worker('a.worker.js')`.
-         * This allows the plugin to compile Module Workers to Classic Workers, which are supported in all browsers.
+         * Override the `type` value output by WorkerPlugin in the worker constructor options.
+         * For example, setting `workerType: 'foo'` will output `new Worker('a.worker.js', { type: 'foo' })`.
+         * Takes precedence over `preserveTypeModule`.
          */
         workerType?: string | undefined;
     }

types/worker-plugin/package.json

@@ -6,14 +6,14 @@
         "https://github.com/GoogleChromeLabs/worker-plugin"
     ],
     "dependencies": {
-        "@types/webpack": "^4"
+        "@types/webpack": "^5"
     },
     "devDependencies": {
         "@types/worker-plugin": "workspace:."
     },
     "owners": [
         {
-            "name": "Artur Androsovych",
+            "name": "arturovt",
             "githubUsername": "arturovt"
         },
         {

types/worker-plugin/worker-plugin-tests.ts

@@ -11,7 +11,9 @@ new WorkerPlugin({
     chunkFilename: "[id]_worker_chunk.js",
 });
 
-class ExistingPlugin extends webpack.Plugin {}
+class ExistingPlugin implements webpack.WebpackPluginInstance {
+    apply(compiler: webpack.Compiler): void {}
+}
 
 const optionsArray: WorkerPlugin.Options[] = [
     {