Skip to content

Commit d0ffd31

Browse files
JanneSaloJanne Salo
andauthored
🤖 Merge PR DefinitelyTyped#74682 [oracledb] Add missing poolPingTimeout to PoolAttributes and Statistics by @JanneSalo
Co-authored-by: Janne Salo <janne.salo@siili.com>
1 parent a94784b commit d0ffd31

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

‎types/oracledb/index.d.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2760,6 +2760,7 @@ declare namespace OracleDB {
27602760
poolIncrement: number;
27612761
poolTimeout: number;
27622762
poolPingInterval: number;
2763+
poolPingTimeout: number;
27632764
poolMaxPerShard: number;
27642765
stmtCacheSize: number;
27652766
sodaMetaDataCache: boolean;
@@ -3245,6 +3246,13 @@ declare namespace OracleDB {
32453246
* @default 60
32463247
*/
32473248
poolPingInterval?: number | undefined;
3249+
/**
3250+
* The number of milliseconds that a connection should wait for a response from connection.ping().
3251+
* This optional property overrides the oracledb.poolPingTimeout property.
3252+
*
3253+
* @default 5000
3254+
*/
3255+
poolPingTimeout?: number | undefined;
32483256
/**
32493257
* The number of seconds after which idle connections (unused in the pool) may be terminated.
32503258
* Idle connections are terminated only when the pool is accessed.

‎types/oracledb/oracledb-tests.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ const runPromiseTests = async (): Promise<void> => {
205205
queueTimeout: 60000,
206206
sessionCallback: initSession,
207207
stmtCacheSize: 5,
208+
poolPingTimeout: 5000,
208209
user: DB_USER,
209210
});
210211

0 commit comments

Comments
 (0)