Fix all packages for noUncheckedSideEffectImports (DefinitelyTyped#73738)

jakebailey · web-flow · commit ea7da0768f11 · 2025-09-24T10:39:15.000-07:00
diff --git a/attw.json b/attw.json
@@ -199,7 +199,6 @@
         "opencc-js",
         "opentok",
         "osmtogeojson",
-        "page-flip",
         "pako",
         "parse-listing",
         "parse/v1",
diff --git a/types/chai-arrays/chai-arrays-tests.ts b/types/chai-arrays/chai-arrays-tests.ts
@@ -1,5 +1,6 @@
+/// <reference types="chai/register-should" />
+
 import ChaiArrays = require("chai-arrays");
-import "chai/register-should";
 
 declare const assert: Chai.AssertStatic;
 declare const expect: Chai.ExpectStatic;
diff --git a/types/chai-fs/chai-fs-tests.ts b/types/chai-fs/chai-fs-tests.ts
@@ -1,5 +1,6 @@
+/// <reference types="chai/register-should" />
+
 import Chaifs = require("chai-fs");
-import "chai/register-should";
 
 declare const assert: Chai.AssertStatic;
 declare const expect: Chai.ExpectStatic;
diff --git a/types/chai-json-schema/chai-json-schema-tests.ts b/types/chai-json-schema/chai-json-schema-tests.ts
@@ -1,6 +1,7 @@
+/// <reference types="chai/register-should" />
+
 import ChaiJsonSchema = require("chai-json-schema");
 import { TV4 } from "tv4";
-import "chai/register-should";
 
 declare const assert: Chai.AssertStatic;
 declare const expect: Chai.ExpectStatic;
diff --git a/types/chai-like/chai-like-tests.ts b/types/chai-like/chai-like-tests.ts
@@ -1,5 +1,6 @@
+/// <reference types="chai/register-should" />
+
 import chaiLike = require("chai-like");
-import "chai/register-should";
 
 declare const expect: Chai.ExpectStatic;
 
diff --git a/types/chai-spies/chai-spies-tests.ts b/types/chai-spies/chai-spies-tests.ts
@@ -1,5 +1,5 @@
+/// <reference types="chai/register-should" />
 import spies = require("chai-spies");
-import "chai/register-should";
 import("chai").then(({ use }) => {
     const chai = use(spies);
 
diff --git a/types/chai-string/chai-string-tests.ts b/types/chai-string/chai-string-tests.ts
@@ -1,9 +1,10 @@
+/// <reference types="chai/register-should" />
+
 declare const assert: Chai.AssertStatic;
 declare const expect: Chai.ExpectStatic;
 
 import chai_string = require("chai-string");
 import("chai").then(({ use }) => use(chai_string));
-import "chai/register-should";
 
 // Stub mocha functions
 const { describe, it, before, after, beforeEach, afterEach } = null as any as {
diff --git a/types/dirty-chai/dirty-chai-tests.ts b/types/dirty-chai/dirty-chai-tests.ts
@@ -1,11 +1,11 @@
+/// <reference types="chai/register-should" />
+
 import chaiAsPromised = require("chai-as-promised");
 import("chai").then(chai => chai.use(chaiAsPromised));
 
 import dirtyChai = require("dirty-chai");
 import("chai").then(chai => chai.use(dirtyChai));
 
-import "chai/register-should";
-
 declare const expect: Chai.ExpectStatic;
 
 // mocha-like stubs so we don't need to use mocha typings
diff --git a/types/hapi/test/server/server-events.ts b/types/hapi/test/server/server-events.ts
@@ -1,7 +1,6 @@
 // https://github.com/hapijs/hapi/blob/master/API.md#-servereventevents
 import { Server, ServerEvents } from "hapi";
 import Podium = require("podium");
-import "hapi/definitions/server/server";
 
 declare module "hapi" {
     interface ServerEvents {
diff --git a/types/hapi/v17/test/server/server-events.ts b/types/hapi/v17/test/server/server-events.ts
@@ -1,7 +1,6 @@
 // https://github.com/hapijs/hapi/blob/master/API.md#-servereventevents
 import { Server, ServerEvents } from "hapi";
 import Podium = require("podium");
-import "hapi/definitions/server/server";
 
 declare module "hapi" {
     interface ServerEvents {
diff --git a/types/karma-chai/index.d.ts b/types/karma-chai/index.d.ts
@@ -1,7 +1,5 @@
-import "chai";
+/// <reference types="chai" />
 
-declare global {
-    var assert: Chai.AssertStatic;
-    var expect: Chai.ExpectStatic;
-    var should: Chai.Should;
-}
+declare var assert: Chai.AssertStatic;
+declare var expect: Chai.ExpectStatic;
+declare var should: Chai.Should;
diff --git a/types/karma-chai/karma-chai-tests.ts b/types/karma-chai/karma-chai-tests.ts
@@ -1,9 +1,5 @@
-/// <reference types="chai" />
-import "chai/register-should";
+/// <reference types="karma-chai" />
 
-declare const expect: Chai.ExpectStatic;
-declare const assert: Chai.AssertStatic;
-
-true.should.be.ok;
 expect(true).to.be.ok;
 assert.isTrue(true);
+should.equal(true, true);
diff --git a/types/node/v18/node-tests.ts b/types/node/v18/node-tests.ts
@@ -9,7 +9,6 @@ import "./test/crypto";
 import "./test/dgram";
 import "./test/diagnostics_channel";
 import "./test/dns";
-import "./test/dom-events"; // dom-events behaves differently under lib-dom
 import "./test/events";
 import "./test/events_generic";
 import "./test/fs";
diff --git a/types/page-flip/dist/PageFlip.d.ts b/types/page-flip/dist/PageFlip.d.ts
@@ -6,7 +6,6 @@ import { Page } from "./Page/Page";
 import { Orientation, Render } from "./Render/Render";
 import { FlipSetting } from "./Settings";
 import { UI } from "./UI/UI";
-import "./Style/stPageFlip.css";
 /**
  * Class representing a main PageFlip object
  */
diff --git a/types/rangy/rangy-tests.ts b/types/rangy/rangy-tests.ts
@@ -1,9 +1,4 @@
 import * as rangy from "rangy";
-import "rangy/lib/rangy-classapplier";
-import "rangy/lib/rangy-highlighter";
-import "rangy/lib/rangy-selectionsaverestore";
-import "rangy/lib/rangy-serializer";
-import "rangy/lib/rangy-textrange";
 
 declare function assertAny(a: any): any;
 declare function assertBoolean(b: boolean): any;
diff --git a/types/react-katex/react-katex-tests.tsx b/types/react-katex/react-katex-tests.tsx
@@ -1,4 +1,3 @@
-import "katex/dist/katex.min.css";
 import * as React from "react";
 import { BlockMath, InlineMath } from "react-katex";
 
diff --git a/types/react-smartbanner/react-smartbanner-tests.tsx b/types/react-smartbanner/react-smartbanner-tests.tsx
@@ -1,6 +1,5 @@
 import React from "react";
 import SmartBanner from "react-smartbanner";
-import "react-smartbanner/dist/main.css";
 
 const EmptySmartBanner: React.FC = () => {
     // @ts-expect-error required parameter 'position' is missing
diff --git a/types/redux-shortcuts/index.d.ts b/types/redux-shortcuts/index.d.ts
@@ -1,6 +1,5 @@
 import { Action, ActionCreator, Dispatch } from "redux";
 import Mousetrap = require("mousetrap");
-import "mousetrap/extensions/global";
 
 export { Mousetrap };
 export const mousetrap: Mousetrap.MousetrapInstance;
diff --git a/types/splitting/splitting-tests.ts b/types/splitting/splitting-tests.ts
@@ -1,6 +1,4 @@
 import Splitting = require("splitting");
-import "splitting/dist/splitting.css";
-import "splitting/dist/splitting-cells.css";
 
 // Base splitting function
 
diff --git a/types/tablesorter/test/Methods.ts b/types/tablesorter/test/Methods.ts
@@ -1,4 +1,3 @@
-import "./Tests";
 import {
     ParsedCell,
     Parser,
diff --git a/types/vue-moment/vue-moment-tests.ts b/types/vue-moment/vue-moment-tests.ts
@@ -1,5 +1,4 @@
 import moment from "moment";
-import "moment/locale/de";
 import Vue from "vue";
 import VueMoment from "vue-moment";
 
diff --git a/types/vue3-carousel-3d/vue3-carousel-3d-tests.ts b/types/vue3-carousel-3d/vue3-carousel-3d-tests.ts
@@ -1,6 +1,5 @@
 import { createApp } from "vue";
 import { Carousel3d, Slide } from "vue3-carousel-3d";
-import "vue3-carousel-3d/dist/index.css";
 
 createApp({
     components: {
diff --git a/types/wonder.js/index.d.ts b/types/wonder.js/index.d.ts
@@ -553,7 +553,6 @@ declare module "wonder.js/dist/es2015/core/Component" {
 declare module "wonder.js/dist/es2015/core/Director" {
     import "wonder-frp/dist/es2015/stream/ConcatStream";
     import "wonder-frp/dist/es2015/stream/IgnoreElementsStream";
-    import "wonder-frp/dist/es2015/extend/root";
     import { SceneDispatcher } from "wonder.js/dist/es2015/core/entityObject/scene/SceneDispatcher";
     import { Renderer } from "wonder.js/dist/es2015/renderer/renderer/Renderer";
     export class Director {
