Skip to content

Commit fd2aec2

Browse files
authored
🤖 Merge PR DefinitelyTyped#73899 feat(nodemailer): flatten nested groups return for addressparser by @hkleungai
1 parent 5b465e2 commit fd2aec2

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

‎types/nodemailer/lib/addressparser/index.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ declare namespace addressparser {
66

77
interface Group {
88
name: string;
9-
group: AddressOrGroup[];
9+
group: Address[];
1010
}
1111

1212
type AddressOrGroup = Address | Group;

‎types/nodemailer/nodemailer-tests.ts‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1543,13 +1543,9 @@ async function mailcomposer_build_promise_test() {
15431543

15441544
// addressparser
15451545

1546-
function isAddress(addressOrGroup: addressparser.AddressOrGroup): addressOrGroup is addressparser.Address {
1547-
return (addressOrGroup as addressparser.Address).address !== undefined;
1548-
}
1546+
declare function isAddress(arg: unknown): arg is addressparser.Address;
15491547

1550-
function isGroup(addressOrGroup: addressparser.AddressOrGroup): addressOrGroup is addressparser.Group {
1551-
return (addressOrGroup as addressparser.Group).group !== undefined;
1552-
}
1548+
declare function isGroup(arg: unknown): arg is addressparser.Group;
15531549

15541550
function addressparser_test() {
15551551
const input = "andris@tr.ee";
@@ -1559,7 +1555,7 @@ function addressparser_test() {
15591555
const address: string = firstResult.address;
15601556
const name: string = firstResult.name;
15611557
} else if (isGroup(firstResult)) {
1562-
const group: addressparser.AddressOrGroup[] = firstResult.group;
1558+
const group: addressparser.Address[] = firstResult.group;
15631559
const name: string = firstResult.name;
15641560
}
15651561
}

0 commit comments

Comments
 (0)