Skip to content

Commit 0af6354

Browse files
fix: meeting ended page server component dto (calcom#25318)
* fix: meeting ended page server component dto * fix: repository function fetching too much
1 parent dd7c553 commit 0af6354

2 files changed

Lines changed: 9 additions & 16 deletions

File tree

apps/web/lib/video/meeting-ended/[uid]/getServerSideProps.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,15 @@ export async function getServerSideProps(context: GetServerSidePropsContext) {
2323
return redirect;
2424
}
2525

26-
const bookingObj = Object.assign({}, booking, {
27-
startTime: booking.startTime.toString(),
28-
endTime: booking.endTime.toString(),
29-
});
26+
// Booking Object DTO, we should not expose any sensitive data through getServerSideProps + server components
27+
const bookingObj = Object.assign(
28+
{},
29+
{
30+
title: booking.title,
31+
startTime: booking.startTime.toString(),
32+
endTime: booking.endTime.toString(),
33+
}
34+
);
3035

3136
return {
3237
props: {

packages/features/bookings/repositories/BookingRepository.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -640,18 +640,6 @@ export class BookingRepository {
640640
select: {
641641
...bookingMinimalSelect,
642642
uid: true,
643-
user: {
644-
select: {
645-
credentials: true,
646-
},
647-
},
648-
references: {
649-
select: {
650-
uid: true,
651-
type: true,
652-
meetingUrl: true,
653-
},
654-
},
655643
},
656644
});
657645
}

0 commit comments

Comments
 (0)