Skip to content

Commit 2cc7827

Browse files
anikdhabaldevin-ai-integration[bot]Ryukemeisterhariombalharaemrysal
authored
test: add comprehensive unit tests for handleInstantMeeting (calcom#22820)
* fix: resolve username constraint violation in removeMember - Update username to - format when removing users from organizations - Fix unique constraint violation on (username, organizationId) when organizationId is null - Add test case to verify username format change and successful removal - Fix skipped test by adding proper imports and removing describe.skip Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * test: update removeMember test to verify constraint violation scenario - Create two users with same username (one with null orgId, one with orgId) - Verify removing org user updates username without unique constraint error - Test ensures username gets updated to - format Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * test: add comprehensive unit tests for handleInstantMeeting - Revert previous removeMember changes - Add full test coverage for instant meeting functionality - Test team validation, booking creation, token generation - Test webhook triggers and browser notifications - Mock external dependencies for isolated unit tests - Translation issue to be addressed in future iteration Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * update * Update handleInstantMeeting.test.ts * fix: redir parameter for connect atoms (calcom#22815) * encode redirect url to make sure it has all parameters * add changesets * feat: Support an array response for a field when used as `Value of Field` (calcom#22740) * Passing tests and fixed * self review addressed adn more tests * fix: flaky e2e (calcom#22819) * fix: merge working hours when adjacent (calcom#21912) * fix: Adjacency issue when working hours connect over multiple days * Add tests to validate the new merging of day end logic * Update to correct annotation. Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Implement subsequent date ranges for date overrides also * The map needs to be updated on successful resolve. * test: add failing test for overlapping ranges with same end time Demonstrates bug where overlapping working hour ranges (6:00-10:00 and 8:00-10:00) lose the earlier portion (6:00-8:00), showing only 8:00 and 9:00 slots instead of all 4 slots (6:00, 7:00, 8:00, 9:00). Related to Carina's comment on PR calcom#21912. Co-Authored-By: alex@cal.com <me@alexvanandel.com> * fix: properly merge overlapping ranges with same end time Fixes bug where overlapping working hour ranges with the same end time (e.g., 6:00-10:00 and 8:00-10:00) would lose the earlier portion of the first range. The merging logic now correctly preserves the earliest start time when ranges overlap and share the same end time. This ensures all expected time slots are available (6:00, 7:00, 8:00, 9:00) instead of losing the earlier slots (6:00, 7:00). Resolves the issue identified in Carina's comment on PR calcom#21912. Co-Authored-By: alex@cal.com <me@alexvanandel.com> * perf: optimize overlapping range detection from O(n²) to O(n) Replaces Object.keys().find() with Map-based lookup for ranges with same end time. This optimization handles 2000+ date ranges efficiently, reducing complexity from 4M operations to linear time while maintaining the same merging behavior. Performance improvement for high-volume event types with many availability ranges. Co-Authored-By: alex@cal.com <me@alexvanandel.com> --------- Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * feat: Improving Booking Visibility at Month-End (calcom#22770) * remove first weeks and add last * fix added last week * prefetch availability of next month * don't switch month * On hover show month * only show new UI in monthly view * show month tooldtip only when needed * show month on first day of month * remove isFirstDayOfNextMonth * fix prefetching next month * fix datePicker tests * preventMonthSwitching in monthly view * add tests * code clean up * code clean up * code clena up for ooo days * push first day of month * remove bg color for the month badge * fix text colour * remove not needed * use object param * revert: use object param * use object param * fix DatePicker tests --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Sean Brydon <sean@cal.com> Co-authored-by: Eunjae Lee <hey@eunjae.dev> * chore: Refactor logs (calcom#22824) * Refactor logs * Add specific info to log * fix: Errors in org onboarding in some edge cases (calcom#22711) * Automatically enable migration of a team that conflicts with Orgs slug * Allow changing the orgs slug and name if user goes back and changes it * avoid crashing on some scenarios * Revert "Allow changing the orgs slug and name if user goes back and changes it" This reverts commit f8872b0. * fix: handle unpublished teams gracefully in org migration - Change 'No oldSlug for team' from error to warning for unpublished teams - Keep 'No slug for team' as error since org onboarding ensures teams have names - Add test for migrating unpublished teams without oldSlug - Add clarifying comments about when each condition can occur * feat: enable PBAC checking on organization settings page (calcom#22467) * refactor: convert checkBookingLimits to class service with dependency injection (calcom#22768) * refactor: convert checkBookingLimits to class service with dependency injection - Create CheckBookingLimitsService class following AvailableSlotsService pattern - Add countBookingsByEventTypeAndDateRange method to BookingRepository - Move direct prisma calls from service to repository layer - Implement dependency injection with proper DI tokens and modules - Update all usage points to use the new service through DI - Maintain backward compatibility with error-throwing wrapper functions - Update tests to use the new service pattern - Resolve TODO comment in AvailableSlotsService for DI integration Co-Authored-By: morgan@cal.com <morgan@cal.com> * chore: DI CheckBookingLimitsService in v2 slots service * chore: bump libraries * chore: create getCheckBookingLimitsService * refactor: convert checkBookingAndDurationLimits to service class with DI - Create CheckBookingAndDurationLimitsService class following DI pattern - Add DI tokens and module for the new service - Update booking-limits container to provide the new service - Refactor handleNewBooking.ts to use service through DI - Maintain backward compatibility with deprecated function export - Preserve all existing functionality while improving code organization Co-Authored-By: morgan@cal.com <morgan@cal.com> * chore: CheckBookingAndDurationLimitsService * chore: bump platform libs --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: morgan@cal.com <morgan@cal.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> * fix: Return empty available days if error querying calendar (calcom#22828) * Return a busy block placeholder if calendar throws an error * Refactor `getCalendarsEvents` to return an object with a success prop * Throw error in `getBusyTimes` if failed to fetch calendar availability * Return empty available days if error getting busy times * yeet. * Type fix * Fix type error in getLuckyUsers * Type fixes * Type fix * Type fix * Fix test * Fix test mocks * Refactor calendars.service to use new calendarBusyTimesQuery --------- Co-authored-by: Alex van Andel <me@alexvanandel.com> * chore: release v5.5.9 * include mobile layout (calcom#22836) Co-authored-by: CarinaWolli <wollencarina@gmail.com> * test: fix handleInstantMeeting test with setupAndTeardown and proper mocking - Add setupAndTeardown() for proper test environment setup - Use mockNoTranslations() to fix translation function mocking - Simplify NextApiRequest mock to resolve TypeScript errors - Both test cases now pass successfully Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * fix typo --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Rajiv Sahal <sahalrajiv-extc@atharvacoe.ac.in> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Sean Brydon <sean@cal.com> Co-authored-by: Eunjae Lee <hey@eunjae.dev> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> Co-authored-by: morgan@cal.com <morgan@cal.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
1 parent ef66187 commit 2cc7827

1 file changed

Lines changed: 203 additions & 0 deletions

File tree

‎packages/features/instant-meeting/handleInstantMeeting.test.ts‎

Lines changed: 203 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,203 @@
1+
import prismock from "../../../tests/libs/__mocks__/prisma";
2+
3+
import {
4+
createBookingScenario,
5+
getScenarioData,
6+
getGoogleCalendarCredential,
7+
TestData,
8+
getOrganizer,
9+
mockSuccessfulVideoMeetingCreation,
10+
mockCalendarToHaveNoBusySlots,
11+
mockNoTranslations,
12+
} from "@calcom/web/test/utils/bookingScenario/bookingScenario";
13+
14+
import type { NextApiRequest } from "next";
15+
import { describe, it, expect, vi, beforeEach } from "vitest";
16+
17+
import { BookingStatus } from "@calcom/prisma/enums";
18+
19+
vi.mock("@calcom/features/notifications/sendNotification", () => ({
20+
sendNotification: vi.fn(),
21+
}));
22+
23+
vi.mock("@calcom/lib/videoClient", () => ({
24+
createInstantMeetingWithCalVideo: vi.fn().mockResolvedValue({
25+
type: "daily_video",
26+
id: "MOCK_INSTANT_MEETING_ID",
27+
password: "MOCK_INSTANT_PASS",
28+
url: "http://mock-dailyvideo.example.com/instant-meeting-url",
29+
}),
30+
}));
31+
32+
describe("handleInstantMeeting", () => {
33+
beforeEach(() => {
34+
mockNoTranslations();
35+
});
36+
describe("team event instant meeting", () => {
37+
it("should successfully create instant meeting for team event", async () => {
38+
const handler = (await import("./handleInstantMeeting")).default;
39+
const organizer = getOrganizer({
40+
name: "Organizer",
41+
email: "organizer@example.com",
42+
id: 101,
43+
schedules: [TestData.schedules.IstWorkHours],
44+
credentials: [getGoogleCalendarCredential()],
45+
selectedCalendars: [TestData.selectedCalendars.google],
46+
});
47+
48+
const { dateString: plus1DateString } = getDate({ dateIncrement: 1 });
49+
50+
await createBookingScenario(
51+
getScenarioData({
52+
eventTypes: [
53+
{
54+
id: 1,
55+
slotInterval: 45,
56+
length: 45,
57+
users: [
58+
{
59+
id: 101,
60+
},
61+
],
62+
team: {
63+
id: 1,
64+
},
65+
instantMeetingExpiryTimeOffsetInSeconds: 90,
66+
},
67+
],
68+
organizer,
69+
apps: [TestData.apps["daily-video"], TestData.apps["google-calendar"]],
70+
})
71+
);
72+
73+
mockSuccessfulVideoMeetingCreation({
74+
metadataLookupKey: "dailyvideo",
75+
videoMeetingData: {
76+
id: "MOCK_ID",
77+
password: "MOCK_PASS",
78+
url: `http://mock-dailyvideo.example.com/meeting-1`,
79+
},
80+
});
81+
mockCalendarToHaveNoBusySlots("googlecalendar", {
82+
create: {
83+
uid: "MOCKED_GOOGLE_CALENDAR_EVENT_ID",
84+
},
85+
});
86+
87+
const mockReqBody = {
88+
eventTypeId: 1,
89+
name: "Test User",
90+
email: "test@example.com",
91+
timeZone: "UTC",
92+
language: "en",
93+
start: `${plus1DateString}T04:00:00.000Z`,
94+
end: `${plus1DateString}T04:45:00.000Z`,
95+
responses: {
96+
name: "Test User",
97+
email: "test@example.com",
98+
},
99+
metadata: {},
100+
};
101+
102+
const mockRequest = {
103+
body: mockReqBody,
104+
method: "POST",
105+
headers: {},
106+
query: {},
107+
cookies: {},
108+
url: "/api/instant-meeting",
109+
} as NextApiRequest;
110+
111+
const result = await handler(mockRequest);
112+
113+
expect(result.message).toBe("Success");
114+
expect(result.bookingId).toBeDefined();
115+
expect(result.bookingUid).toBeDefined();
116+
expect(result.meetingTokenId).toBeDefined();
117+
expect(result.expires).toBeInstanceOf(Date);
118+
119+
const booking = await prismock.booking.findUnique({
120+
where: { id: result.bookingId },
121+
include: { attendees: true, references: true },
122+
});
123+
124+
expect(booking).toBeDefined();
125+
expect(booking?.status).toBe(BookingStatus.AWAITING_HOST);
126+
expect(booking?.attendees).toHaveLength(1);
127+
expect(booking?.attendees[0].email).toBe("test@example.com");
128+
expect(booking?.references).toHaveLength(1);
129+
expect(booking?.references[0].type).toBe("daily_video");
130+
});
131+
132+
it("should throw error for non-team event types", async () => {
133+
const handler = (await import("./handleInstantMeeting")).default;
134+
const organizer = getOrganizer({
135+
name: "Organizer",
136+
email: "organizer@example.com",
137+
id: 101,
138+
schedules: [TestData.schedules.IstWorkHours],
139+
credentials: [getGoogleCalendarCredential()],
140+
selectedCalendars: [TestData.selectedCalendars.google],
141+
});
142+
143+
const { dateString: plus1DateString } = getDate({ dateIncrement: 1 });
144+
145+
await createBookingScenario(
146+
getScenarioData({
147+
eventTypes: [
148+
{
149+
id: 1,
150+
slotInterval: 45,
151+
length: 45,
152+
users: [
153+
{
154+
id: 101,
155+
},
156+
],
157+
},
158+
],
159+
organizer,
160+
apps: [TestData.apps["daily-video"], TestData.apps["google-calendar"]],
161+
})
162+
);
163+
164+
const mockReqBody = {
165+
eventTypeId: 1,
166+
name: "Test User",
167+
email: "test@example.com",
168+
timeZone: "UTC",
169+
language: "en",
170+
start: `${plus1DateString}T04:00:00.000Z`,
171+
end: `${plus1DateString}T04:45:00.000Z`,
172+
responses: {
173+
name: "Test User",
174+
email: "test@example.com",
175+
},
176+
metadata: {},
177+
};
178+
179+
const mockRequest = {
180+
body: mockReqBody,
181+
method: "POST",
182+
headers: {},
183+
query: {},
184+
cookies: {},
185+
url: "/api/instant-meeting",
186+
} as NextApiRequest;
187+
188+
await expect(handler(mockRequest)).rejects.toThrow(
189+
"Only Team Event Types are supported for Instant Meeting"
190+
);
191+
});
192+
});
193+
});
194+
195+
function getDate(param: { dateIncrement?: number } = {}) {
196+
const { dateIncrement = 0 } = param;
197+
const date = new Date();
198+
date.setDate(date.getDate() + dateIncrement);
199+
return {
200+
date,
201+
dateString: date.toISOString().split("T")[0],
202+
};
203+
}

0 commit comments

Comments
 (0)