Skip to content

Commit 6c620e3

Browse files
refactor: remove redundant filtering in service (calcom#25874)
* refactor: remove redundant filtering and return filtered users from service * Simplify user retrieval by returning users directly * Fix formatting issue in users.service.ts * Filter out null users in getDynamicEventType --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
1 parent 5bfbec6 commit 6c620e3

1 file changed

Lines changed: 1 addition & 8 deletions

File tree

apps/api/v2/src/modules/users/services/users.service.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,7 @@ export class UsersService {
2828
const users = await Promise.all(
2929
usernames.map((username) => this.usersRepository.findByUsername(username, orgSlug, orgId))
3030
);
31-
const usersFiltered: User[] = [];
32-
33-
for (const user of users) {
34-
if (user) {
35-
usersFiltered.push(user);
36-
}
37-
}
38-
31+
3932
return users;
4033
}
4134

0 commit comments

Comments
 (0)