Skip to content

Commit a234007

Browse files
fix: prevent buttons from looking active when interacting with parent divs (calcom#25431)
1 parent 33c3bf3 commit a234007

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

packages/ui/components/button/Button.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ export const Button = forwardRef<HTMLAnchorElement | HTMLButtonElement, ButtonPr
273273
name={StartIcon}
274274
className={classNames(
275275
loading ? "invisible" : "visible",
276-
"button-icon group-active:translate-y-[0.5px]",
276+
"button-icon group-[:not(div):active]:translate-y-[0.5px]",
277277
variant === "icon" && "h-4 w-4",
278278
variant === "button" && "h-4 w-4 stroke-[1.5px] "
279279
)}
@@ -286,7 +286,7 @@ export const Button = forwardRef<HTMLAnchorElement | HTMLButtonElement, ButtonPr
286286
"contents", // This makes the div behave like it doesn't exist in the layout
287287
loading ? "invisible" : "visible",
288288
variant === "fab" ? "hidden md:contents" : "",
289-
"group-active:translate-y-[0.5px]"
289+
"group-[:not(div):active]:translate-y-[0.5px]"
290290
)}>
291291
{props.children}
292292
</div>
@@ -321,7 +321,7 @@ export const Button = forwardRef<HTMLAnchorElement | HTMLButtonElement, ButtonPr
321321
name={EndIcon}
322322
className={classNames(
323323
loading ? "invisible" : "visible",
324-
"group-active:translate-y-[0.5px]",
324+
"group-[:not(div):active]:translate-y-[0.5px]",
325325
variant === "icon" && "h-4 w-4",
326326
variant === "button" && "h-4 w-4 stroke-[1.5px] "
327327
)}

0 commit comments

Comments
 (0)