Skip to content

Commit a71d62d

Browse files
fix(ui): change phone booking display from Organizer Phone Number to Phone Call (calcom#27636)
* fix(ui): change phone booking display from Organizer Phone Number to Phone Call The label \"Organizer Phone Number\" was confusing for attendees on the booking page, as it exposed internal terminology. Replaced with the more user-friendly \"Phone Call\" label across the booking UI, companion app, and test assertions. Closes calcom#13010 * fix: remove duplicate phone_call i18n key The phone_call key already existed in en/common.json (line 1685, Cal.ai Voice Agent section). Removed the duplicate entry we added. Found by ai-codex review.
1 parent a8ede77 commit a71d62d

6 files changed

Lines changed: 9 additions & 9 deletions

File tree

apps/web/components/dialog/__tests__/EditLocationDialog.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ vi.mock("@calcom/features/form/components/LocationSelect", () => {
4747
});
4848

4949
const AttendeePhoneNumberLabel = "Attendee phone number";
50-
const OrganizerPhoneLabel = "Organizer phone number";
50+
const OrganizerPhoneLabel = "Phone call";
5151
const CampfireLabel = "Campfire";
5252
const ZoomVideoLabel = "Zoom Video";
5353
const OrganizerDefaultConferencingAppLabel = "Organizer's default app";
@@ -202,7 +202,7 @@ describe("EditLocationDialog", () => {
202202
});
203203

204204
describe("Team Booking Case", () => {
205-
it("should not show Attendee Phone Number but show Organizer Phone Number and dynamic link Conferencing apps", async () => {
205+
it("should not show Attendee Phone Number but show Phone Call option and dynamic link Conferencing apps", async () => {
206206
render(<EditLocationDialog {...mockProps} booking={{ location: "Office" }} teamId={1} />);
207207

208208
expect(screen.queryByText(AttendeePhoneNumberLabel)).not.toBeInTheDocument();

apps/web/playwright/event-types.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ test.describe("Event Types tests", () => {
365365
await page.getByTestId(removeButtomId).nth(0).click();
366366
await page.getByTestId(removeButtomId).nth(0).click();
367367

368-
// Add Multiple Organizer Phone Number options
368+
// Add Multiple Phone Call location options
369369
await page.getByTestId("location-select").last().click();
370370
await page.getByTestId("location-select-item-userPhone").click();
371371

companion/components/event-type-detail/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export const defaultLocations = [
6262
{ label: "Organizer Address", type: "inPerson" as const },
6363
{ label: "Link Meeting", type: "link" as const },
6464
{ label: "Attendee Phone Number", type: "phone" as const },
65-
{ label: "Organizer Phone Number", type: "userPhone" as const },
65+
{ label: "Phone Call", type: "userPhone" as const },
6666
];
6767

6868
export const tabs = [

companion/utils/defaultLocations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export const defaultLocations: DefaultLocation[] = [
7171
},
7272
{
7373
type: DefaultLocationType.UserPhone,
74-
label: "Organizer Phone Number",
74+
label: "Phone Call",
7575
iconUrl: "https://app.cal.com/phone.svg",
7676
category: "phone",
7777
organizerInputType: "phone",

companion/utils/locationHelpers.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export function mapApiLocationToItem(apiLocation: ApiLocation): LocationItem {
8383
id,
8484
type: "phone",
8585
phone: apiLocation.phone || "",
86-
displayName: "Organizer Phone Number",
86+
displayName: "Phone Call",
8787
iconUrl: "https://app.cal.com/phone.svg",
8888
public: apiLocation.public,
8989
};
@@ -198,7 +198,7 @@ export function getLocationDisplayName(locationType: string, integration?: strin
198198
address: "In Person (Organizer Address)",
199199
attendeeAddress: "In Person (Attendee Address)",
200200
link: "Link Meeting",
201-
phone: "Organizer Phone Number",
201+
phone: "Phone Call",
202202
attendeePhone: "Attendee Phone Number",
203203
attendeeDefined: "Custom Attendee Location",
204204
};

packages/app-store/locations.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ export const defaultLocations: DefaultEventLocationType[] = [
192192
{
193193
default: true,
194194
type: DefaultEventLocationTypeEnum.UserPhone,
195-
label: "organizer_phone_number",
195+
label: "phone_call",
196196
messageForOrganizer: "Provide your phone number",
197197
organizerInputType: "phone",
198198
organizerInputLabel: "phone_number",
@@ -209,7 +209,7 @@ const translateAbleKeys = [
209209
"in_person",
210210
"attendee_phone_number",
211211
"link_meeting",
212-
"organizer_phone_number",
212+
"phone_call",
213213
"organizer_default_conferencing_app",
214214
"somewhere_else",
215215
"custom_attendee_location",

0 commit comments

Comments
 (0)