Skip to content

Commit c554396

Browse files
fix: Remove Reporting page within Routing Forms (calcom#22990)
1 parent fafd3fb commit c554396

4 files changed

Lines changed: 1 addition & 343 deletions

File tree

packages/app-store/routing-forms/pages/app-routing.client-config.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@ export const routingFormsComponents = {
22
"form-edit": () => import("./form-edit/[...appPages]").then((mod) => mod.default),
33
"route-builder": () => import("./route-builder/[...appPages]").then((mod) => mod.default),
44
"routing-link": () => import("./routing-link/[...appPages]").then((mod) => mod.default),
5-
reporting: () => import("./reporting/[...appPages]").then((mod) => mod.default),
65
"incomplete-booking": () => import("./incomplete-booking/[...appPages]").then((mod) => mod.default),
76
};

packages/app-store/routing-forms/pages/reporting/[...appPages].tsx

Lines changed: 0 additions & 292 deletions
This file was deleted.

packages/app-store/routing-forms/playwright/tests/basic.e2e.ts

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -408,52 +408,6 @@ test.describe("Routing Forms", () => {
408408
// Log back in to view form responses.
409409
await user.apiLogin();
410410

411-
await page.goto(`/routing-forms/reporting/${routingForm.id}`);
412-
413-
const headerEls = page.locator("[data-testid='reporting-header'] th");
414-
415-
// Wait for the headers to be visible(will automaically wait for getting response from backend) along with it the rows are rendered.
416-
await headerEls.first().waitFor();
417-
418-
const numHeaderEls = await headerEls.count();
419-
const headers = [];
420-
for (let i = 0; i < numHeaderEls; i++) {
421-
headers.push(await headerEls.nth(i).innerText());
422-
}
423-
424-
const responses = [];
425-
const responseRows = page.locator("[data-testid='reporting-row']");
426-
const numResponseRows = await responseRows.count();
427-
for (let i = 0; i < numResponseRows; i++) {
428-
const rowLocator = responseRows.nth(i).locator("td");
429-
const numRowEls = await rowLocator.count();
430-
const rowResponses = [];
431-
for (let j = 0; j < numRowEls; j++) {
432-
rowResponses.push(await rowLocator.nth(j).innerText());
433-
}
434-
responses.push(rowResponses);
435-
}
436-
437-
expect(headers).toEqual([
438-
"Test field",
439-
"Multi Select(with Legacy `selectText`)",
440-
"Multi Select",
441-
"Legacy Select",
442-
"Select",
443-
// TODO: Find a way to incorporate Routed To and Booked At into the report
444-
// @see https://github.com/calcom/cal.com/pull/17229
445-
"Routed To",
446-
"Assignment Reason",
447-
"Booked At",
448-
"Submitted At",
449-
]);
450-
/* Last two columns are "Routed To" and "Booked At" */
451-
expect(responses).toEqual([
452-
["custom-page", "Option-2", "Option-2", "Option-2", "Option-2", "", "", "", expect.any(String)],
453-
["external-redirect", "Option-2", "Option-2", "Option-2", "Option-2", "", "", "", expect.any(String)],
454-
["event-routing", "Option-2", "Option-2", "Option-2", "Option-2", "", "", "", expect.any(String)],
455-
]);
456-
457411
await page.goto(`apps/routing-forms/route-builder/${routingForm.id}`);
458412

459413
const downloadPromise = page.waitForEvent("download");

packages/features/shell/Shell.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import { useAppTheme } from "./useAppTheme";
2727
const Layout = (props: LayoutProps) => {
2828
const { banners, bannersHeight } = useBanners();
2929
const pathname = usePathname();
30-
const isFullPageWithoutSidebar = pathname?.startsWith("/apps/routing-forms/reporting/");
3130

3231
useFormbricks();
3332

@@ -40,9 +39,7 @@ const Layout = (props: LayoutProps) => {
4039
<TimezoneChangeDialog />
4140

4241
<div className="flex min-h-screen flex-col">
43-
{banners && !props.isPlatformUser && !isFullPageWithoutSidebar && (
44-
<BannerContainer banners={banners} />
45-
)}
42+
{banners && !props.isPlatformUser && <BannerContainer banners={banners} />}
4643

4744
<div className="flex flex-1" data-testid="dashboard-shell">
4845
{props.SidebarContainer ? (

0 commit comments

Comments
 (0)