fix: Bunch of fixes and minor changes throughout the app (calcom#23356)

* Bunch of fixes and minor changes throughout the app

* remove logs

* fix: e2e

* fix: e2e

* fix: more e2e and design

* revert insights upgrade change

Author: Amit91848

apps/web/app/(use-page-wrapper)/(main-nav)/teams/CTA.tsx

@@ -11,6 +11,7 @@ export const TeamsCTA = () => {
       data-testid="new-team-btn"
       variant="fab"
       StartIcon="plus"
+      size="sm"
       type="button"
       href={`${WEBAPP_URL}/settings/teams/new?returnTo=${WEBAPP_URL}/teams`}>
       {t("new")}

apps/web/app/(use-page-wrapper)/settings/(settings-layout)/SettingsLayoutAppDirClient.tsx

@@ -438,13 +438,15 @@ const TeamListCollapsible = ({ teamFeatures }: { teamFeatures?: Record<number, T
                       name={t("profile")}
                       href={`/settings/teams/${team.id}/profile`}
                       textClassNames="px-3 text-emphasis font-medium text-sm"
+                      className="me-5 h-7 w-auto !px-2"
                       disableChevron
                     />
                   )}
                   <VerticalTabItem
                     name={t("members")}
                     href={`/settings/teams/${team.id}/members`}
                     textClassNames="px-3 text-emphasis font-medium text-sm"
+                    className="me-5 h-7 w-auto !px-2"
                     disableChevron
                   />
                   {/* Show roles only for sub-teams with PBAC-enabled parent */}
@@ -465,6 +467,7 @@ const TeamListCollapsible = ({ teamFeatures }: { teamFeatures?: Record<number, T
                         name={t("appearance")}
                         href={`/settings/teams/${team.id}/appearance`}
                         textClassNames="px-3 text-emphasis font-medium text-sm"
+                        className="me-5 h-7 w-auto !px-2"
                         disableChevron
                       />
                       {/* Hide if there is a parent ID */}
@@ -474,6 +477,7 @@ const TeamListCollapsible = ({ teamFeatures }: { teamFeatures?: Record<number, T
                             name={t("billing")}
                             href={`/settings/teams/${team.id}/billing`}
                             textClassNames="px-3 text-emphasis font-medium text-sm"
+                            className="me-5 h-7 w-auto !px-2"
                             disableChevron
                           />
                         </>
@@ -482,6 +486,7 @@ const TeamListCollapsible = ({ teamFeatures }: { teamFeatures?: Record<number, T
                         name={t("settings")}
                         href={`/settings/teams/${team.id}/settings`}
                         textClassNames="px-3 text-emphasis font-medium text-sm"
+                        className="me-5 h-7 w-auto !px-2"
                         disableChevron
                       />
                     </>
@@ -643,6 +648,7 @@ const SettingsSidebarContainer = ({
                         name={t("add_a_team")}
                         href={`${WEBAPP_URL}/settings/teams/new`}
                         textClassNames="px-3 items-center mt-2 text-emphasis font-medium text-sm"
+                        className="me-5 h-7 w-auto !px-2"
                         icon="plus"
                         disableChevron
                       />
@@ -744,12 +750,14 @@ const SettingsSidebarContainer = ({
                                   name={t("profile")}
                                   href={`/settings/organizations/teams/other/${otherTeam.id}/profile`}
                                   textClassNames="px-3 text-emphasis font-medium text-sm"
+                                  className="me-5 h-7 w-auto !px-2"
                                   disableChevron
                                 />
                                 <VerticalTabItem
                                   name={t("members")}
                                   href={`/settings/organizations/teams/other/${otherTeam.id}/members`}
                                   textClassNames="px-3 text-emphasis font-medium text-sm"
+                                  className="me-5 h-7 w-auto !px-2"
                                   disableChevron
                                 />
                                 <>

apps/web/components/dialog/__tests__/EditLocationDialog.test.tsx

@@ -81,7 +81,7 @@ describe("EditLocationDialog", () => {
               },
               {
                 value: "integrations:daily",
-                label: "Cal Video (Global)",
+                label: "Cal Video (Default)",
                 disabled: false,
                 icon: "/app-store/dailyvideo/icon.svg",
                 slug: "daily-video",

apps/web/modules/signup-view.tsx

@@ -426,6 +426,7 @@ export default function Signup({
                     id="signup-email"
                     {...register("email")}
                     label={t("email")}
+                    placeholder="john@doe.com"
                     type="email"
                     autoComplete="email"
                     disabled={prepopulateFormValues?.email}
@@ -522,8 +523,8 @@ export default function Signup({
                         usernameTaken
                       }>
                       {premiumUsername && !usernameTaken
-                        ? `${t("create_account")} (${getPremiumPlanPriceValue()})`
-                        : t("create_account")}
+                        ? `${t("get_started")} (${getPremiumPlanPriceValue()})`
+                        : t("get_started")}
                     </Button>
                   )}
                 </Form>

apps/web/playwright/event-types.e2e.ts

@@ -239,7 +239,7 @@ test.describe("Event Types tests", () => {
         await gotoFirstEventType(page);
 
         await page.getByTestId("location-select").click();
-        await page.locator(`text="Cal Video (Global)"`).click();
+        await page.locator(`text="Cal Video (Default)"`).click();
 
         await saveEventType(page);
         await gotoBookingPage(page);
@@ -282,7 +282,7 @@ test.describe("Event Types tests", () => {
         await selectAttendeePhoneNumber(page);
 
         // Add Cal Video location
-        await addAnotherLocation(page, "Cal Video (Global)");
+        await addAnotherLocation(page, "Cal Video (Default)");
 
         await saveEventType(page);
 
@@ -496,6 +496,9 @@ test.describe("Event Types tests", () => {
       });
       await test.step("should open first eventType and check Interface Language", async () => {
         await gotoFirstEventType(page);
+        // Go to Advanced tab
+        await page.click("[data-testid=vertical-tab-event_advanced_tab_title]");
+        await page.click("[data-testid=event-interface-language-toggle]");
         const interfaceLanguageValue = page
           .getByTestId("event-interface-language")
           .locator('div[class$="-singleValue"]');
@@ -518,6 +521,9 @@ test.describe("Event Types tests", () => {
 
       await test.step("should open first eventType and change Interface Language to Deutsche", async () => {
         await gotoFirstEventType(page);
+        // Go to Advanced tab and enable offerSeats
+        await page.click("[data-testid=vertical-tab-event_advanced_tab_title]");
+        await page.click("[data-testid=event-interface-language-toggle]");
         await page.getByTestId("event-interface-language").click();
         await page.locator(`text="Deutsch"`).click();
         await saveEventType(page);
@@ -574,6 +580,9 @@ test.describe("Event Types tests", () => {
         await page.goto("/event-types");
         await page.waitForSelector('[data-testid="event-types"]');
         await gotoFirstEventType(page);
+        // Go to Advanced tab and enable offerSeats
+        await page.click("[data-testid=vertical-tab-event_advanced_tab_title]");
+        await page.click("[data-testid=event-interface-language-toggle]");
         await page.getByTestId("event-interface-language").click();
         await page.getByTestId("select-option-es").click();
         await saveEventType(page);

apps/web/playwright/filter-helpers.ts

@@ -198,7 +198,7 @@ export async function expectSegmentCleared(page: Page) {
   // Check that no segment is selected (button shows default text)
   const segmentSelect = page.getByTestId("filter-segment-select");
   const buttonText = await segmentSelect.textContent();
-  expect(buttonText?.trim()).toEqual("Segment");
+  expect(buttonText?.trim()).toEqual("Saved filters");
 }
 
 /**

apps/web/playwright/fixtures/regularBookings.ts

@@ -199,6 +199,7 @@ export function createBookingPageFixture(page: Page) {
       await expect(eventTypePage.getByTestId("time")).toHaveCount(count);
     },
     getAITranslationToggleDisabled: async () => {
+      await page.click("[data-testid=vertical-tab-event_advanced_tab_title]");
       await page.waitForSelector('[data-testid="ai_translation_toggle"]', {
         timeout: 5000,
         state: "attached",
@@ -207,6 +208,7 @@ export function createBookingPageFixture(page: Page) {
       return (await toggle.getAttribute("disabled")) !== null;
     },
     toggleAITranslation: async () => {
+      await page.click("[data-testid=vertical-tab-event_advanced_tab_title]");
       await page.getByTestId("ai_translation_toggle").click();
     },
     updateEventTypeDescription: async (description: string) => {

apps/web/playwright/managed-event-types.e2e.ts

@@ -81,10 +81,13 @@ test.describe("Managed Event Types", () => {
     await page.goto(`/event-types/${managedEvent.id}?tabName=setup`);
     await expect(page.getByTestId("vertical-tab-basics")).toHaveAttribute("aria-current", "page"); // fix the race condition
     await expect(page.getByTestId("vertical-tab-basics")).toContainText("Basics"); //fix the race condition
+
     await page.locator("#location-select").click();
-    const optionText = await getByKey(page, "organizer_default_conferencing_app");
-    await expect(optionText).toBeVisible();
-    await optionText.click();
+    const targetText = (await localize("en"))("organizer_default_conferencing_app");
+    const options = page.locator('[data-testid="location-select-item-conferencing"]');
+    const targetOption = options.locator(`text=${targetText}`);
+    await expect(targetOption).toBeVisible();
+    await targetOption.click();
     await saveAndWaitForResponse(page);
 
     await page.getByTestId("vertical-tab-assignment").click();
@@ -190,7 +193,7 @@ test.describe("Managed Event Types", () => {
   });
 
   const MANAGED_EVENT_TABS: { slug: string; locator: (page: Page) => Locator | Promise<Locator> }[] = [
-    { slug: "setup", locator: (page) => getByKey(page, "translate_description_button") },
+    { slug: "setup", locator: (page) => getByKey(page, "allow_multiple_durations") },
     {
       slug: "team",
       locator: (page) => getByKey(page, "automatically_add_all_team_members"),

apps/web/public/static/locales/en/common.json

@@ -321,6 +321,7 @@
   "secret_meeting": "Secret Meeting",
   "login_instead": "Login instead",
   "create_account": "Create Account",
+  "get_started": "Get started",
   "confirm_password": "Confirm password",
   "reset_your_password": "Set your new password with the instructions sent to your email address.",
   "org_banner_instructions": "Please upload image of {{width}} width and {{height}} height.",
@@ -958,7 +959,7 @@
   "light_event_type_color": "Event Type Color (Light Theme)",
   "dark_event_type_color": "Event Type Color (Dark Theme)",
   "file_not_named": "File is not named [idOrSlug]/[user]",
-  "create_team": "Create Team",
+  "create_team": "Create team",
   "name": "Name",
   "nameless_team": "Nameless Team",
   "oauth_clients": "OAuth Clients",
@@ -1019,6 +1020,7 @@
   "attendees": "Attendees",
   "add_attendees": "Add attendees",
   "show_advanced_settings": "Show advanced settings",
+  "hide_advanced_settings": "Hide advanced settings",
   "event_name": "Event Name",
   "event_name_in_calendar": "Calendar event name",
   "event_name_tooltip": "The name that will appear in calendars",
@@ -1231,7 +1233,7 @@
   "contact_sales": "Contact Sales",
   "error_404": "Error 404",
   "default": "Default",
-  "set_to_default": "Set to Default",
+  "set_to_default": "Set as Default",
   "new_schedule_btn": "New schedule",
   "add_new_schedule": "Add a new schedule",
   "add_new_calendar": "Add a new calendar",
@@ -1329,7 +1331,7 @@
   "make_team_private_description": "Your team members won't be able to see other team members when this is turned on.",
   "you_cannot_see_team_members": "You cannot see all the team members of a private team.",
   "you_cannot_see_teams_of_org": "You cannot see teams of a private organization.",
-  "allow_booker_to_select_duration": "Allow booker to select from multiple durations",
+  "allow_multiple_durations": "Allow multiple durations",
   "impersonate_user_tip": "All uses of this feature is audited.",
   "impersonating_user_warning": "Impersonating username \"{{user}}\".",
   "impersonating_stop_instructions": "Click here to stop",
@@ -2689,7 +2691,7 @@
   "enterprise": "Enterprise",
   "enterprise_description": "Upgrade to Enterprise to create your Organization",
   "create_your_org": "Create your Organization",
-  "create_org": "Create Organization",
+  "create_org": "Create organization",
   "create_your_org_description": "Upgrade to Organizations and receive a subdomain, unified billing, Insights, extensive whitelabeling and more",
   "create_your_enterprise_description": "Upgrade to Enterprise and get access to Active Directory Sync, SCIM Automatic User provisioning, Cal.ai Voice Agents, Admin APIs and more!",
   "other_payment_app_enabled": "You can only enable one payment app per event type",
@@ -2923,6 +2925,7 @@
   "proceeding_agreement": "By proceeding, you agree to our",
   "terms": "Terms",
   "always_show_x_days": "Always {{x}} days available",
+  "always_show_x_days_description": "Automatically moves the {{x}}-day booking window forward each day, ensuring your calendar always shows the next {{x}} days of available slots.",
   "team_subscription_cancelled_successfully": "Team subscription cancelled successfully",
   "team_subscription_cancellation_error": "Error while cancelling the team subscription",
   "unable_to_subscribe_to_the_platform": "An error occurred while trying to subscribe to the platform plan, please try again later",
@@ -3144,7 +3147,8 @@
   "filter_operator_ends_with": "Ends with",
   "filter_operator_is_empty": "Is empty",
   "filter_operator_not_empty": "Not empty",
-  "translate_description_button": "Translate title/description to the visitor's browser language using AI",
+  "translate_description_button": "Auto translate title and description",
+  "translate_description_button_description": "Automatically translate titles and descriptions to the visitor’s browser language using AI.",
   "rr_distribution_method": "Distribution",
   "rr_distribution_method_description": "Allows for optimising distribution for maximum availability or to aim for a more balanced assignment.",
   "rr_distribution_method_availability_title": "Maximize availability",
@@ -3310,6 +3314,7 @@
   "seats_doesnt_support_recurring": "Seats feature doesn't support recurring event. Disable seats feature to make it recurring.",
   "recurring_event_seats_error": "Recurring event doesn't support seats feature. Disable seats feature or make the event non-recurring.",
   "segment": "Segment",
+  "saved_filters": "Saved filters",
   "rename": "Rename",
   "rename_segment": "Rename Segment",
   "delete_segment": "Delete Segment",
@@ -3339,6 +3344,7 @@
   "picklist": "Picklist",
   "most_cancelled_bookings": "Most Cancelled",
   "interface_language": "Interface Language",
+  "interface_language_description": "Set your preferred language for the booking interface",
   "visitors_browser_language": "Visitor's browser language",
   "name_or_email": "Name or Email",
   "salesforce_round_robin_skip_fallback_to_lead_owner": "If no contact is found, fallback to lead owner if it exists",
@@ -3571,8 +3577,8 @@
   "rr_load_balancing_disabled_with_groups": "Load Balancing is not available with Round Robin Groups",
   "round_robin_settings_description": "Customize the default round robin settings for this team",
   "round_robin_settings_updated_successfully": "Round Robin settings updated successfully",
-  "booking_creation_time": "Booking Creation Time",
-  "meeting_start_time": "Meeting Start Time",
+  "booking_creation_time": "Booking creation time",
+  "meeting_start_time": "Meeting start time",
   "members_affected_by_disabling_delegation_credential": "Affected members",
   "no_members_affected_by_disabling_delegation_credential": "No members affected by disabling delegation credential",
   "download_expense_log": "Download Expense Log",

packages/app-store/utils.ts

@@ -68,7 +68,7 @@ function getApps(credentials: CredentialDataWithTeamName[], filterOnCredentials?
         delegatedToId: null,
         delegationCredentialId: null,
         team: {
-          name: "Global",
+          name: "Default",
         },
       };
       logger.debug(