[pull] master from flameshot-org:master#157
Merged
pull[bot] merged 2 commits intoUncodedtech:masterfrom Aug 12, 2025
Merged
Conversation
* Fix dual monitor offset bug in Qt6 multi-monitor setups The issue was caused by using QApplication::primaryScreen() to capture the entire desktop, but in Qt6 the primary screen is not necessarily the leftmost screen. This caused coordinate system misalignment in multi-monitor setups where the primary screen is positioned to the right. Additionally, the previous approach failed in edge cases where screens have different heights and the desktop bounding box includes virtual space that doesn't correspond to any physical screen. Changes: - Replace single-screen desktop capture with composite approach - Capture each screen individually and composite them together - Position capture widget to cover entire desktop geometry - Remove devicePixelRatio division that caused coordinate issues - Handle virtual desktop space by filling with black background This solution works with any multi-monitor configuration including: - Primary screen not being leftmost - Screens with different resolutions and alignments - Bottom-aligned or top-aligned screen arrangements - Complex layouts with virtual coordinate space Fixes #4111 * Fix clang-format issue --------- Co-authored-by: ionsquare <ionsquare@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )