[pull] master from flameshot-org:master#232
Merged
pull[bot] merged 3 commits intoUncodedtech:masterfrom Apr 12, 2026
Merged
Conversation
The clipboard copy from tray menu and capture GUI was broken on macOS:
1. FlameshotDaemon::copyToClipboard() created a KDSingleApplication
instance and called isPrimaryInstance(), which always returned false
(the daemon already holds the socket). This caused a 3-second IPC
timeout before falling back. Fix: use instance() to check if the
daemon singleton exists in-process, matching non-macOS behavior.
2. saveToClipboardMime() used setData("image/...") which puts a lazy
reference on the macOS pasteboard. If the app exits before paste,
data is lost ("Cannot keep promise"). Fix: use setImageData() for
native pasteboard persistence, plus setData() for exact format.
3. saveJpegToClipboardMacOS() used osascript with a temp file and
incorrectly labeled JPEG data as PNG UTI. Removed entirely — the
fixed saveToClipboardMime() now handles both JPEG and PNG.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )