fix(ci): move Docker environment vars to environment

Author: xmatthias

.github/workflows/ci.yml

@@ -422,8 +422,6 @@ jobs:
       packages: write # Needed to push package versions
       contents: read
     secrets:
-      DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
-      DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
       DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK }}
 
 

.github/workflows/docker-build.yml

@@ -3,10 +3,6 @@ name: Docker Build and Deploy
 on:
   workflow_call:
     secrets:
-      DOCKER_PASSWORD:
-        required: true
-      DOCKER_USERNAME:
-        required: true
       DISCORD_WEBHOOK:
         required: false
   workflow_dispatch:
@@ -35,6 +31,8 @@ jobs:
     name: "Deploy Docker x64 and armv7l"
     runs-on: ubuntu-22.04
     if: github.repository == 'freqtrade/freqtrade'
+    environment:
+      name: docker
 
     steps:
     - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -59,8 +57,8 @@ jobs:
     - name: Login to Docker Hub
       uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
       with:
-        username: ${{ secrets.DOCKER_USERNAME }}
-        password: ${{ secrets.DOCKER_PASSWORD }}
+        username: ${{ secrets.DOCKERHUB_USERNAME }}
+        password: ${{ secrets.DOCKERHUB_TOKEN }}
 
     - name: Set up QEMU
       uses: docker/setup-qemu-action@c7c53464625b32c7a7e944ae62b3e17d2b600130 # v3.7.0
@@ -168,6 +166,8 @@ jobs:
     # Only run on 64bit machines
     runs-on: [self-hosted, linux, ARM64]
     if: github.repository == 'freqtrade/freqtrade'
+    environment:
+      name: docker
 
     steps:
     - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -181,8 +181,8 @@ jobs:
     - name: Login to Docker Hub
       uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
       with:
-        username: ${{ secrets.DOCKER_USERNAME }}
-        password: ${{ secrets.DOCKER_PASSWORD }}
+        username: ${{ secrets.DOCKERHUB_USERNAME }}
+        password: ${{ secrets.DOCKERHUB_TOKEN }}
 
     - name: Login to github
       uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0

.github/workflows/docker-update-readme.yml

@@ -15,6 +15,8 @@ jobs:
   dockerHubDescription:
     name: "Update Docker Hub Description"
     runs-on: ubuntu-latest
+    environment:
+      name: docker
     steps:
     - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       with:
@@ -23,6 +25,6 @@ jobs:
     - name: Docker Hub Description
       uses: peter-evans/dockerhub-description@1b9a80c056b620d92cedb9d9b5a223409c68ddfa # v5.0.0
       with:
-        username: ${{ secrets.DOCKER_USERNAME }}
-        password: ${{ secrets.DOCKER_PASSWORD }}
+        username: ${{ secrets.DOCKERHUB_USERNAME }}
+        password: ${{ secrets.DOCKERHUB_TOKEN }}
         repository: freqtradeorg/freqtrade