Config: Drop unreachable DatabaseDriverName switch cases photoprism#5588

Author: lastzero

internal/config/config_db.go

@@ -52,15 +52,14 @@ func (c *Config) DatabaseDriver() string {
 	return c.options.DatabaseDriver
 }
 
-// DatabaseDriverName returns the formatted database driver name.
+// DatabaseDriverName returns the formatted database driver name. Input is
+// always canonical after DatabaseDriver(); the default arm is defensive.
 func (c *Config) DatabaseDriverName() string {
 	switch c.DatabaseDriver() {
-	case dsn.DriverMySQL, dsn.DriverMariaDB:
+	case dsn.DriverMySQL:
 		return "MariaDB"
-	case dsn.DriverSQLite3, "sqlite", "test", "file", "":
+	case dsn.DriverSQLite3:
 		return "SQLite"
-	case "tidb":
-		return "TiDB"
 	default:
 		return "unsupported database"
 	}

internal/config/config_db_test.go

@@ -44,10 +44,38 @@ func TestConfig_DatabaseDriver(t *testing.T) {
 }
 
 func TestConfig_DatabaseDriverName(t *testing.T) {
-	c := NewConfig(CliTestContext())
-	resetDatabaseOptions(c)
-	driver := c.DatabaseDriverName()
-	assert.Equal(t, "SQLite", driver)
+	t.Run("DefaultsToSQLite", func(t *testing.T) {
+		c := NewConfig(CliTestContext())
+		resetDatabaseOptions(c)
+		assert.Equal(t, "SQLite", c.DatabaseDriverName())
+	})
+	t.Run("MySQLReportsAsMariaDB", func(t *testing.T) {
+		c := NewConfig(CliTestContext())
+		resetDatabaseOptions(c)
+		c.options.DatabaseDriver = dsn.DriverMySQL
+		assert.Equal(t, "MariaDB", c.DatabaseDriverName())
+	})
+	t.Run("MariaDBAliasReportsAsMariaDB", func(t *testing.T) {
+		// "mariadb" collapses onto DriverMySQL in ParseDriver; format stays "MariaDB".
+		c := NewConfig(CliTestContext())
+		resetDatabaseOptions(c)
+		c.options.DatabaseDriver = dsn.DriverMariaDB
+		assert.Equal(t, "MariaDB", c.DatabaseDriverName())
+	})
+	t.Run("DeprecatedTiDBReportsAsSQLite", func(t *testing.T) {
+		// DatabaseDriver() warns and rewrites "tidb" to SQLite3 before this runs.
+		c := NewConfig(CliTestContext())
+		resetDatabaseOptions(c)
+		c.options.DatabaseDriver = "tidb"
+		assert.Equal(t, "SQLite", c.DatabaseDriverName())
+	})
+	t.Run("UnknownDriverReportsAsSQLite", func(t *testing.T) {
+		// DatabaseDriver() coerces unknown drivers to SQLite3 before this runs.
+		c := NewConfig(CliTestContext())
+		resetDatabaseOptions(c)
+		c.options.DatabaseDriver = "oracle"
+		assert.Equal(t, "SQLite", c.DatabaseDriverName())
+	})
 }
 
 func TestConfig_DatabaseVersion(t *testing.T) {