Skip to content

Commit f88e85e

Browse files
committed
Frontend: Mount face-marker overlay in read-only display mode for viewers
Drops shouldShowEditButton() from the <p-face-marker-overlay> v-if so non-editable users (Plus / Pro viewer role, anyone reaching the eye toggle in the sidebar) actually see marker rectangles AND the in-overlay Back button when they activate display mode. The previous gate required edit permission, so viewers entered face-marker mode (chrome hidden), saw nothing, and had no way to exit. Edit gestures stay gated separately by the overlay's isEditMode flag and the lightbox-side onCreateFaceMarker / onRemoveFaceMarker / toggleFaceMarkerEdit handlers that re-check shouldShowEditButton(). Pre-existing bug; surfaced while testing the recent ACL-driven sidebar refactor (photoprism#4966).
1 parent 1d6698d commit f88e85e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

frontend/src/component/lightbox.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
>
4545
<div ref="lightbox" tabindex="-1" class="p-lightbox__pswp no-transition"></div>
4646
<p-face-marker-overlay
47-
v-if="shouldShowEditButton() && featPeople && faceMarkers.active && pswp()"
47+
v-if="featPeople && faceMarkers.active && pswp()"
4848
ref="faceMarkerOverlay"
4949
:mode="faceMarkers.mode"
5050
:markers="markers"

0 commit comments

Comments
 (0)