chore: simplify lerna publish command and improve image loading with Promise.all

matteobruni · matteobruni · commit 940a4db7659b · 2026-02-04T16:27:24.000+01:00
diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml
@@ -62,9 +62,7 @@ jobs:
         run: |
           TAG="${GITHUB_REF#refs/tags/}"
           
-          # --provenance: Fondamentale per OIDC e sicurezza nel 2026
-          # --yes: Evita blocchi interattivi in CI
-          BASE_CMD="npx lerna publish from-package --ignore-scripts --provenance --yes"
+          BASE_CMD="npx lerna publish from-package --ignore-scripts"
 
           echo "Publishing tag: $TAG via OIDC"
 
diff --git a/lerna.json b/lerna.json
@@ -13,5 +13,6 @@
       "yes": true
     }
   },
+  "useNx": true,
   "$schema": "node_modules/lerna/schemas/lerna-schema.json"
 }
diff --git a/shapes/image/src/ImageDrawer.ts b/shapes/image/src/ImageDrawer.ts
@@ -84,9 +84,13 @@ export class ImageDrawer implements IShapeDrawer<ImageParticle> {
       return;
     }
 
+    const promises: Promise<void>[] = [];
+
     for (const imageData of options.preload) {
-      await this._engine.loadImage(imageData);
+      promises.push(this._engine.loadImage(imageData));
     }
+
+    await Promise.all(promises);
   }
 
   loadShape(particle: ImageParticle): void {

Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,6 @@`
`13`	`13`	`"yes": true`
`14`	`14`	`}`
`15`	`15`	`},`
	`16`	`+ "useNx": true,`
`16`	`17`	`"$schema": "node_modules/lerna/schemas/lerna-schema.json"`
`17`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,9 +84,13 @@ export class ImageDrawer implements IShapeDrawer<ImageParticle> {`
`84`	`84`	`return;`
`85`	`85`	`}`
`86`	`86`
	`87`	`+ const promises: Promise<void>[] = [];`
	`88`	`+`
`87`	`89`	`for (const imageData of options.preload) {`
`88`		`- await this._engine.loadImage(imageData);`
	`90`	`+ promises.push(this._engine.loadImage(imageData));`
`89`	`91`	`}`
	`92`	`+`
	`93`	`+ await Promise.all(promises);`
`90`	`94`	`}`
`91`	`95`
`92`	`96`	`loadShape(particle: ImageParticle): void {`