better profile mode with no dogcheck#1553
Open
Romualdo666 wants to merge 33 commits into
Open
Conversation
The current profile's name is shown on the main window, Profiles names can be custom and added buttons to export profiles to the current data.win's folder, and import them back to the appdata.
Fixed the issue where automatic comments would duplicate and the one where the custom Profile name window would show up even if Profile mode weren't enabled.
When opening a data.win, all the code in the Temp Profile folder is replaced with the main, and when saving, all the main is replaced with the temp. this, to avoid wrong overwriting. Also, exporting profiles will actually overwrite the already exported profiles, and importing too. Fixed the issue where Importing Profiles wouldn't edit the dissasembly code.
Fixed a bug when using the default MD5Hash as the name for the profile when saving, and now the profile's name is the same on the folder. (In other words, the appdata folder, instead of being a MD5Hash of the Profile name, will simply be the Profile's name.)
doesn't work yet
This reverts commit f2c4e63.
it does the same but now when you close it asks if you want to save so you really don't lose that much progress!
loading a profile automatically applies its code to dissasembly plus fixed some bugs related to importing code.
this should work, hence on should since i havent tested it out yet.
removed dogcheck and some other changes.
This reverts commit 29a9a96.
|
Download the artifacts for this pull request here: GUI:
CLI: |
Contributor
Author
|
@Miepee hopefully last ping, sorry. |
Miepee
requested changes
Nov 27, 2023
this has the dogcheck and the room editor improvements made by another user
Contributor
|
If you still want to merge this in, you should probably rebase this correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improved profile mode with different profiles system as if it was a project with automatic code loading and all!
Caveats
My code's a mess, appreciated if someone tries to fix it.
Notes
I may or may not have grabbed stuff from other branches and modified them to improve. The only one I remember currently is that one pull request that would let you move on rooms with right click. I changed that and made it be able to move by holding space (like in Gamemaker Studio)