Skip to content

[NewTextureRepacker] Group textures to dump by their texture page to prevent explosive memory growth #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
longnguyen2004 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[NewTextureRepacker] Group textures to dump by their texture page to prevent explosive memory growth #2109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions UndertaleModTool/Scripts/Resource Repackers/NewTextureRepacker.csx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,13 +238,21 @@ TPageItem dumpTexturePageItem(UndertaleTexturePageItem pageItem, TextureWorker w

async Task<List<TPageItem>> dumpTexturePageItems(string dir, bool reuse)
{
using var worker = new TextureWorker();
var groupedByTexturePage = Data.TexturePageItems
.GroupBy(item => item.TexturePage.ToString());

var tpageitems = await Task.Run(() => Data.TexturePageItems
.AsParallel()
.Select(item => dumpTexturePageItem(item, worker, Path.Combine(dir, $"texture_page_{Data.TexturePageItems.IndexOf(item)}.png"), reuse))
.ToList());
var tpageitems = new List<TPageItem>();
foreach (var group in groupedByTexturePage)
{
using var worker = new TextureWorker();

var tpageitemsNew = await Task.Run(() => group
.AsParallel()
.Select(item => dumpTexturePageItem(item, worker, Path.Combine(dir, $"texture_page_{Data.TexturePageItems.IndexOf(item)}.png"), reuse))
.ToList());

tpageitems.AddRange(tpageitemsNew);
}
return tpageitems;
}

Expand Down