Small code cleanup, improved FancyRoomSelect.csx#2236
Merged
Conversation
Dobby233Liu
reviewed
Sep 6, 2025
| reader.SubmitWarning("Null pointers found in pointer list on file built with GMS pre-2!"); | ||
| } | ||
| i--; count--; | ||
| reader.SubmitWarning("Null pointers found in pointer list on file built with GMS pre 2024.11!"); |
Contributor
There was a problem hiding this comment.
This was completely supposed to say "pre-2". At least one GMS1 game (see #2020) is known to be like this
Dobby233Liu
reviewed
Sep 6, 2025
Co-authored-by: Liu Wenyuan <15816141883@163.com>
Contributor
Author
|
my bad, i fixed those two mistakes now |
colinator27
approved these changes
Jan 17, 2026
Member
colinator27
left a comment
colinator27
left a comment
There was a problem hiding this comment.
Did a whole bunch of cleanup and refactors on top of the existing ones in this PR, and fixed up some compilation/accuracy issues. Seems good to merge now, thanks!
|
Download the artifacts for this pull request here: GUI:
CLI: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No new features, just a bit of cleanup up code.
Actually, there is a new feature: You can now press Ctrl+Backspace when using the room picker in
FancyRoomSelect.csxto delete the entire query.Caveats
Might be few nanoseconds less efficient; I don't know how well C# optimises code.
Notes
I couldn't compile the UI project (UndertaleModTool) because I don't have access to Windows right now.