Skip to content

perf(scripts): improve sound export throughput#2398

Open
cmdr-chara wants to merge 1 commit into
UnderminersTeam:masterfrom
cmdr-chara:cmdr-chara/export-all-sounds-perf
Open

perf(scripts): improve sound export throughput#2398
cmdr-chara wants to merge 1 commit into
UnderminersTeam:masterfrom
cmdr-chara:cmdr-chara/export-all-sounds-perf

Conversation

@cmdr-chara

Copy link
Copy Markdown

Summary

  • Improves ExportAllSounds.csx throughput by caching audio group lookups, avoiding repeated directory creation, and writing/copying export jobs with bounded parallelism.
  • Preserves output filenames and contents for the tested Undertale export case.

Testing

  • Compared upstream script vs this change on UNDERTALE/data.win.
  • Output matched: 443 files, 128,007,271 bytes, 0 missing/extra/changed files by SHA-256.
  • 3-run median: 4412 ms -> 4082 ms (~7.5% faster).

Risks

  • Tested with Undertale data.win; other GameMaker titles may exercise different external audio layouts.

@cmdr-chara

cmdr-chara commented Jun 26, 2026

Copy link
Copy Markdown
Author

@colinator27 Could you please check the code? This script was improved in my WinUI fork, but I'd like for it to be included here as well.

@cmdr-chara cmdr-chara marked this pull request as ready for review June 26, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant