New IDEVersion struct in GeneralInfo for convenience#2406
Open
BioTomateDE wants to merge 1 commit into
Open
Conversation
BioTomateDE
force-pushed
the
versionstruct
branch
from
48d3c80 to
f42b664
Compare
|
Download the artifacts for this pull request here: GUI:
CLI: |
BioTomateDE
force-pushed
the
versionstruct
branch
from
69d3c46 to
6d6940f
Compare
Contributor
|
Interesting, although you'd have to be careful that it doesn't break XAML bindings and such (Fody would probably be doing a lot the heavy lifting here). I think it would be better to decouple the version as in the data file and the detected version by UTMT. You might as well combine both the version number and the branch into a single object at that point. |
Contributor
Author
|
we can have an additional OriginalVersion field that denotes the read gen8 version. thats probably better right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made a new struct called IDEVersion that contains major, minor, release, build and LTS branch. UndertaleGeneralInfo now stores this in a new field called Version. You can still use GeneralInfo.Major to access GeneralInfo.Version.Major etc using a properties. This ensures this change does not break existing code (and is more convenient anyway).
The reason I implemented this is because I think this could be useful when handling GameMaker versions without needing to create a whole UndertaleGeneralInfo or making your own struct/tuple for the 5 different version parts.
Caveats
no
Notes
if you don't like the name IDEVersion I can change it to something else lol