Merge pull request #1409 from Unidata/issue1408

allow non-unitary strides when slicing vlen vars (issue #1408)

Author: jswhit

Changelog

@@ -6,6 +6,7 @@
    perform a membership operation on a Dataset (issue #1383)
  * fix type hint for createEnumType (issue #1378)
  * add python 3.13 to windows wheel builds (PR #1377)
+ * allow slicing of vlen and string variables with non-unitary strides (issue #1408).
 
  version 1.7.2 (tag v1.7.2rel)
  =============================

src/netCDF4/_netCDF4.pyx

@@ -5966,10 +5966,9 @@ NC_CHAR).
                         ierr = nc_put_vara(self._grpid, self._varid,
                                            startp, countp, strdata)
                 else:
-                    raise IndexError('strides must all be 1 for string variables')
-                    #with nogil:
-                    #    ierr = nc_put_vars(self._grpid, self._varid,
-                    #                       startp, countp, stridep, strdata)
+                    with nogil:
+                        ierr = nc_put_vars(self._grpid, self._varid,
+                                           startp, countp, stridep, strdata)
                 _ensure_nc_success(ierr)
                 free(strdata)
             else:
@@ -5995,10 +5994,9 @@ NC_CHAR).
                         ierr = nc_put_vara(self._grpid, self._varid,
                                            startp, countp, vldata)
                 else:
-                    raise IndexError('strides must all be 1 for vlen variables')
-                    #with nogil:
-                    #    ierr = nc_put_vars(self._grpid, self._varid,
-                    #                       startp, countp, stridep, vldata)
+                    with nogil:
+                        ierr = nc_put_vars(self._grpid, self._varid,
+                                           startp, countp, stridep, vldata)
                 _ensure_nc_success(ierr)
                 # free the pointer array.
                 free(vldata)
@@ -6091,11 +6089,9 @@ NC_CHAR).
                         ierr = nc_get_vara(self._grpid, self._varid,
                                            startp, countp, strdata)
                 else:
-                    # FIXME: is this a bug in netCDF4?
-                    raise IndexError('strides must all be 1 for string variables')
-                    #with nogil:
-                    #    ierr = nc_get_vars(self._grpid, self._varid,
-                    #                       startp, countp, stridep, strdata)
+                    with nogil:
+                        ierr = nc_get_vars(self._grpid, self._varid,
+                                           startp, countp, stridep, strdata)
                 if ierr == NC_EINVALCOORDS:
                     raise IndexError
                 elif ierr != NC_NOERR:
@@ -6130,10 +6126,9 @@ NC_CHAR).
                         ierr = nc_get_vara(self._grpid, self._varid,
                                            startp, countp, vldata)
                 else:
-                    raise IndexError('strides must all be 1 for vlen variables')
-                    #with nogil:
-                    #    ierr = nc_get_vars(self._grpid, self._varid,
-                    #                       startp, countp, stridep, vldata)
+                    with nogil:
+                        ierr = nc_get_vars(self._grpid, self._varid,
+                                           startp, countp, stridep, vldata)
                 if ierr == NC_EINVALCOORDS:
                     raise IndexError
                 elif ierr != NC_NOERR:

test/test_vlen.py

@@ -76,6 +76,15 @@ def runTest(self):
                 assert_array_equal(data2[j,i], data[j,i])
                 assert datas[j,i] == data2s[j,i]
         assert_array_equal(datas, vs_alt[:])
+        # issue #1408
+        data2a = data2[::2,::2]
+        data2b = v[::2,::2]
+        data2sa = data2s[::2,::2]
+        data2sb = vs[::2,::2]
+        for i in range(nlons//2):
+            for j in range(nlats//2):
+                assert_array_equal(data2a[j,i], data2b[j,i])
+                assert_array_equal(data2sa[j,i], data2sb[j,i])
         f.close()