chore: update invariant tests#337
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
zhongeric
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
mgretzke
reviewed
May 22, 2026
|
|
||
| // The invariant MAY be broken IF the clearingPrice was rounded up by one wei. | ||
| if (purchasableSupplyQ96X7 < remainingSupplyQ96X7) { | ||
| uint256 allowableBuffer = 1 * (sumDemandQ96 * ConstantsLib.MPS); |
Contributor
There was a problem hiding this comment.
I have trouble following why the buffer is dependent on the demand, if it is actually about the supply? This buffer seems extremely big and forgiving, which kind of defeats the purpose of the test.
Contributor
Author
There was a problem hiding this comment.
It's because clearingPrice can be rounded up, which would result in 1 * sumDemandQ96 overshoot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade invariant tests: