Skip to content

misc: update solc to 0.8.28 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
worm-emoji wants to merge 2 commits into
base: main
Choose a base branch
from
Open

misc: update solc to 0.8.28 #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7193dd5
misc: update solc to 0.8.28
worm-emoji Feb 12, 2025
9526cfe
check in snapshots
worm-emoji Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[profile.default]
out = 'foundry-out'
solc_version = '0.8.26'
solc_version = '0.8.28'
optimizer_runs = 44444444
via_ir = true
ffi = true
Expand Down
2 changes: 1 addition & 1 deletion snapshots/BaseActionsRouterTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"BaseActionsRouter_mock10commands": "63076"
"BaseActionsRouter_mock10commands": "63062"
}
6 changes: 0 additions & 6 deletions snapshots/PaymentsTests.json
View file
Open in desktop

This file was deleted.

80 changes: 40 additions & 40 deletions snapshots/PosMGasTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,43 @@
{
"PositionManager_burn_empty": "51102",
"PositionManager_burn_empty_native": "51102",
"PositionManager_burn_nonEmpty_native_withClose": "127695",
"PositionManager_burn_nonEmpty_native_withTakePair": "127137",
"PositionManager_burn_nonEmpty_withClose": "134600",
"PositionManager_burn_nonEmpty_withTakePair": "134043",
"PositionManager_collect_native": "147732",
"PositionManager_collect_sameRange": "156364",
"PositionManager_collect_withClose": "156364",
"PositionManager_collect_withTakePair": "155679",
"PositionManager_decreaseLiquidity_native": "113681",
"PositionManager_decreaseLiquidity_withClose": "121933",
"PositionManager_decreaseLiquidity_withTakePair": "121248",
"PositionManager_decrease_burnEmpty": "137500",
"PositionManager_decrease_burnEmpty_native": "130595",
"PositionManager_decrease_sameRange_allLiquidity": "134649",
"PositionManager_decrease_take_take": "122490",
"PositionManager_increaseLiquidity_erc20_withClose": "160652",
"PositionManager_increaseLiquidity_erc20_withSettlePair": "159563",
"PositionManager_increaseLiquidity_native": "143532",
"PositionManager_increase_autocompoundExactUnclaimedFees": "138231",
"PositionManager_increase_autocompoundExcessFeesCredit": "179593",
"PositionManager_increase_autocompound_clearExcess": "149511",
"PositionManager_mint_native": "367550",
"PositionManager_mint_nativeWithSweep_withClose": "376153",
"PositionManager_mint_nativeWithSweep_withSettlePair": "375348",
"PositionManager_mint_onSameTickLower": "319298",
"PositionManager_mint_onSameTickUpper": "319940",
"PositionManager_mint_sameRange": "245522",
"PositionManager_mint_settleWithBalance_sweep": "420760",
"PositionManager_mint_warmedPool_differentRange": "325316",
"PositionManager_mint_withClose": "421910",
"PositionManager_mint_withSettlePair": "420939",
"PositionManager_multicall_initialize_mint": "458237",
"PositionManager_permit": "79163",
"PositionManager_permit_secondPosition": "62075",
"PositionManager_permit_twice": "44975",
"PositionManager_subscribe": "87968",
"PositionManager_burn_empty": "51100",
"PositionManager_burn_empty_native": "51100",
"PositionManager_burn_nonEmpty_native_withClose": "127684",
"PositionManager_burn_nonEmpty_native_withTakePair": "127127",
"PositionManager_burn_nonEmpty_withClose": "134591",
"PositionManager_burn_nonEmpty_withTakePair": "134033",
"PositionManager_collect_native": "147721",
"PositionManager_collect_sameRange": "156354",
"PositionManager_collect_withClose": "156354",
"PositionManager_collect_withTakePair": "155669",
"PositionManager_decreaseLiquidity_native": "113671",
"PositionManager_decreaseLiquidity_withClose": "121921",
"PositionManager_decreaseLiquidity_withTakePair": "121236",
"PositionManager_decrease_burnEmpty": "137491",
"PositionManager_decrease_burnEmpty_native": "130584",
"PositionManager_decrease_sameRange_allLiquidity": "134637",
"PositionManager_decrease_take_take": "122478",
"PositionManager_increaseLiquidity_erc20_withClose": "160642",
"PositionManager_increaseLiquidity_erc20_withSettlePair": "159553",
"PositionManager_increaseLiquidity_native": "143523",
"PositionManager_increase_autocompoundExactUnclaimedFees": "138223",
"PositionManager_increase_autocompoundExcessFeesCredit": "179581",
"PositionManager_increase_autocompound_clearExcess": "149501",
"PositionManager_mint_native": "367541",
"PositionManager_mint_nativeWithSweep_withClose": "376144",
"PositionManager_mint_nativeWithSweep_withSettlePair": "375339",
"PositionManager_mint_onSameTickLower": "319288",
"PositionManager_mint_onSameTickUpper": "319930",
"PositionManager_mint_sameRange": "245512",
"PositionManager_mint_settleWithBalance_sweep": "420748",
"PositionManager_mint_warmedPool_differentRange": "325306",
"PositionManager_mint_withClose": "421900",
"PositionManager_mint_withSettlePair": "420929",
"PositionManager_multicall_initialize_mint": "458225",
"PositionManager_permit": "79175",
"PositionManager_permit_secondPosition": "62063",
"PositionManager_permit_twice": "44963",
"PositionManager_subscribe": "87967",
"PositionManager_unsubscribe": "62697",
"position manager initcode hash (without constructor params, as uint256)": "81827502601055975118808937107769364319765058198432540518516360048852193272922",
"positionManager bytecode size": "23877"
"position manager initcode hash (without constructor params, as uint256)": "16849313585573942656357380918713937130885258120975441288701273909606764574034",
"positionManager bytecode size": "23875"
}
4 changes: 2 additions & 2 deletions snapshots/PositionDescriptorTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"position descriptor initcode hash (without constructor params, as uint256)": "62242073579002066175147720437850721791653757771535856244007756965162378120375",
"positionDescriptor bytecode size": "24069",
"position descriptor initcode hash (without constructor params, as uint256)": "37195973998998764862337934415051299645404063430957787644591274446399664899027",
"positionDescriptor bytecode size": "24071",
"proxy bytecode size": "1488"
}
15 changes: 0 additions & 15 deletions snapshots/QuoterTest.json
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions snapshots/StateViewTest.json
View file
Open in desktop

This file was deleted.

48 changes: 24 additions & 24 deletions snapshots/V4RouterTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
{
"V4Router_Bytecode": "8975",
"V4Router_ExactIn1Hop_nativeIn": "121653",
"V4Router_ExactIn1Hop_nativeOut": "120119",
"V4Router_ExactIn1Hop_oneForZero": "128991",
"V4Router_ExactIn1Hop_zeroForOne": "135517",
"V4Router_ExactIn2Hops": "192843",
"V4Router_ExactIn2Hops_nativeIn": "178979",
"V4Router_ExactIn3Hops": "250218",
"V4Router_ExactIn3Hops_nativeIn": "236354",
"V4Router_ExactInputSingle": "134001",
"V4Router_ExactInputSingle_nativeIn": "120137",
"V4Router_ExactInputSingle_nativeOut": "118581",
"V4Router_ExactOut1Hop_nativeIn_sweepETH": "127940",
"V4Router_ExactOut1Hop_nativeOut": "121329",
"V4Router_ExactOut1Hop_oneForZero": "130201",
"V4Router_ExactOut1Hop_zeroForOne": "134858",
"V4Router_ExactOut2Hops": "191291",
"V4Router_ExactOut2Hops_nativeIn": "184373",
"V4Router_ExactOut3Hops": "247788",
"V4Router_ExactOut3Hops_nativeIn": "240870",
"V4Router_ExactOut3Hops_nativeOut": "224943",
"V4Router_ExactOutputSingle": "133337",
"V4Router_ExactOutputSingle_nativeIn_sweepETH": "126419",
"V4Router_ExactOutputSingle_nativeOut": "119821",
"router initcode hash (without constructor params, as uint256)": "27545762869727400677117557485685740862616789454191614676777323590122002226479"
"V4Router_ExactIn1Hop_nativeIn": "121629",
"V4Router_ExactIn1Hop_nativeOut": "120093",
"V4Router_ExactIn1Hop_oneForZero": "128966",
"V4Router_ExactIn1Hop_zeroForOne": "135492",
"V4Router_ExactIn2Hops": "192810",
"V4Router_ExactIn2Hops_nativeIn": "178947",
"V4Router_ExactIn3Hops": "250177",
"V4Router_ExactIn3Hops_nativeIn": "236314",
"V4Router_ExactInputSingle": "133978",
"V4Router_ExactInputSingle_nativeIn": "120115",
"V4Router_ExactInputSingle_nativeOut": "118557",
"V4Router_ExactOut1Hop_nativeIn_sweepETH": "127915",
"V4Router_ExactOut1Hop_nativeOut": "121304",
"V4Router_ExactOut1Hop_oneForZero": "130177",
"V4Router_ExactOut1Hop_zeroForOne": "134834",
"V4Router_ExactOut2Hops": "191260",
"V4Router_ExactOut2Hops_nativeIn": "184341",
"V4Router_ExactOut3Hops": "247750",
"V4Router_ExactOut3Hops_nativeIn": "240831",
"V4Router_ExactOut3Hops_nativeOut": "224904",
"V4Router_ExactOutputSingle": "133315",
"V4Router_ExactOutputSingle_nativeIn_sweepETH": "126396",
"V4Router_ExactOutputSingle_nativeOut": "119798",
"router initcode hash (without constructor params, as uint256)": "62372135275657248938241348240506139257617876737139502018490669086511582556785"
}
2 changes: 1 addition & 1 deletion src/PositionDescriptor.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: MIT
pragma solidity 0.8.26;
pragma solidity 0.8.28;

import {IPoolManager} from "@uniswap/v4-core/src/interfaces/IPoolManager.sol";
import {Currency} from "@uniswap/v4-core/src/types/Currency.sol";
Expand Down
2 changes: 1 addition & 1 deletion src/PositionManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: MIT
pragma solidity 0.8.26;
pragma solidity 0.8.28;

import {IPoolManager} from "@uniswap/v4-core/src/interfaces/IPoolManager.sol";
import {PoolKey} from "@uniswap/v4-core/src/types/PoolKey.sol";
Expand Down
2 changes: 1 addition & 1 deletion src/UniswapV4DeployerCompetition.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: MIT
pragma solidity 0.8.26;
pragma solidity 0.8.28;

import {Create2} from "@openzeppelin/contracts/utils/Create2.sol";
import {VanityAddressLib} from "./libraries/VanityAddressLib.sol";
Expand Down
2 changes: 1 addition & 1 deletion src/V4Router.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: MIT
pragma solidity 0.8.26;
pragma solidity 0.8.28;

import {IPoolManager} from "@uniswap/v4-core/src/interfaces/IPoolManager.sol";
import {BalanceDelta} from "@uniswap/v4-core/src/types/BalanceDelta.sol";
Expand Down
2 changes: 1 addition & 1 deletion src/interfaces/IUniswapV4DeployerCompetition.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: MIT
pragma solidity 0.8.26;
pragma solidity 0.8.28;

/// @title IUniswapV4DeployerCompetition
/// @notice Interface for the UniswapV4DeployerCompetition contract
Expand Down