Skip to content

docs: clarify network source comments #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scosemicolon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: clarify network source comments #965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/network/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class Network extends Connector {
if (Array.isArray(urls)) {
accumulator[Number(chainId)] = urls
} else {
// this ternary just makes typescript happy, since it can't infer that the array has elements of the same type
// this ternary just makes TypeScript happy, since it can't infer that the array has elements of the same type
accumulator[Number(chainId)] = isUrl(urls) ? [urls] : [urls]
}

Expand All @@ -66,7 +66,7 @@ export class Network extends Connector {

const urls = this.urlMap[chainId]

// early return if we have a single jsonrpc provider already
// early return if we have a single JSON-RPC provider already
if (urls.length === 1 && !isUrl(urls[0])) {
return (this.providerCache[chainId] = Promise.resolve(urls[0]))
}
Expand Down