Skip to content

Set scene for all files#324

Merged
Lipen merged 1 commit into
neofrom
lipen/ets-scene
Jun 3, 2025
Merged

Set scene for all files#324
Lipen merged 1 commit into
neofrom
lipen/ets-scene

Conversation

@Lipen
Copy link
Copy Markdown
Member

@Lipen Lipen commented Jun 2, 2025

This PR fixes #320 by setting the .scene property to the enclosing EtsScene for all project and SDK files in scene.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2025

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 29s ⏱️ -1s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 3c5dfd4. ± Comparison against base commit bccc018.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2025

Test results on JDK 8

 68 files  ±0   68 suites  ±0   4m 36s ⏱️ +4s
569 tests ±0  557 ✅ ±0  12 💤 ±0  0 ❌ ±0 
597 runs  ±0  585 ✅ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit 3c5dfd4. ± Comparison against base commit bccc018.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.99%. Comparing base (bccc018) to head (3c5dfd4).
Report is 1 commits behind head on neo.

Additional details and impacted files
@@            Coverage Diff            @@
##                neo     #324   +/-   ##
=========================================
  Coverage     76.99%   76.99%           
  Complexity     2439     2439           
=========================================
  Files           211      211           
  Lines         12308    12308           
  Branches       1935     1935           
=========================================
+ Hits           9476     9477    +1     
  Misses         2012     2012           
+ Partials        820      819    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2025

Test results on JDK 19

 68 files  ±0   68 suites  ±0   4m 46s ⏱️ +8s
569 tests ±0  560 ✅ ±0  9 💤 ±0  0 ❌ ±0 
597 runs  ±0  588 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 3c5dfd4. ± Comparison against base commit bccc018.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2025

Test results on JDK 11

 68 files  ±0   68 suites  ±0   5m 10s ⏱️ ±0s
569 tests ±0  562 ✅ ±0  7 💤 ±0  0 ❌ ±0 
597 runs  ±0  590 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit 3c5dfd4. ± Comparison against base commit bccc018.

@Lipen Lipen requested a review from CaelmBleidd June 2, 2025 16:45
@Lipen Lipen merged commit f37e723 into neo Jun 3, 2025
13 checks passed
@Lipen Lipen deleted the lipen/ets-scene branch June 3, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants