Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors TypeScript literal type support by replacing the generic EtsLiteralType with specific literal type classes for different value types. The refactoring changes the single EtsLiteralType data class into a sealed interface with three implementing data classes: EtsStringLiteralType, EtsNumberLiteralType, and EtsBooleanLiteralType.
- Converts
EtsLiteralTypefrom a data class to a sealed interface - Adds three specific literal type implementations with type-safe value storage
- Updates the visitor pattern to handle each literal type separately
- Enhances JSON deserialization to properly handle different literal value types
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Type.kt | Refactors literal type hierarchy from single class to sealed interface with three implementations |
| Convert.kt | Updates JSON-to-type conversion to map literal values to appropriate type classes |
| EtsFromJsonTest.kt | Adds comprehensive test coverage for all literal type variants |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
CaelmBleidd
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds proper support for different TS literal types: string/number/boolean. Each literal class is now represented as a separate
data classunder thesealed interface EtsLiteralType.