no more shell: true + remove util._extends

Author: Unitech

lib/API/Modules/LOCAL.js

@@ -106,7 +106,6 @@ function installLangModule(module_name, cb) {
   var install_instance = spawn(cst.IS_WINDOWS ? 'npm.cmd' : 'npm', ['install', module_name, '--loglevel=error'], {
     stdio : 'inherit',
     env: process.env,
-		shell : true,
     cwd : node_module_path
   });
 

lib/API/Modules/NPM.js

@@ -180,27 +180,24 @@ function install(CLI, module_name, opts, cb) {
 // Builtin Node Switch
 function getNPMCommandLine(module_name, install_path) {
   if (which('bun')) {
-    return spawn.bind(this, 'bun', ['install', module_name, '--loglevel=error', '--cwd', `"${install_path}"` ], {
+    return spawn.bind(this, 'bun', ['install', module_name, '--loglevel=error', '--cwd', install_path], {
       stdio : 'inherit',
       env: process.env,
-      windowsHide: true,
-      shell : true
+      windowsHide: true
     })
   }
   else if (which('npm')) {
-    return spawn.bind(this, cst.IS_WINDOWS ? 'npm.cmd' : 'npm', ['install', module_name, '--loglevel=error', '--prefix', `"${install_path}"` ], {
+    return spawn.bind(this, cst.IS_WINDOWS ? 'npm.cmd' : 'npm', ['install', module_name, '--loglevel=error', '--prefix', install_path], {
       stdio : 'inherit',
       env: process.env,
-      windowsHide: true,
-      shell : true
+      windowsHide: true
     })
   }
   else {
-    return spawn.bind(this, cst.BUILTIN_NODE_PATH, [cst.BUILTIN_NPM_PATH, 'install', module_name, '--loglevel=error', '--prefix', `"${install_path}"`], {
+    return spawn.bind(this, cst.BUILTIN_NODE_PATH, [cst.BUILTIN_NPM_PATH, 'install', module_name, '--loglevel=error', '--prefix', install_path], {
       stdio : 'inherit',
       env: process.env,
-      windowsHide: true,
-      shell : true
+      windowsHide: true
     })
   }
 }

lib/API/Modules/TAR.js

@@ -58,8 +58,7 @@ function retrieveRemote(url, dest, cb) {
   var wget = spawn('wget', [url, '-O', dest, '-q'], {
     stdio : 'inherit',
     env: process.env,
-    windowsHide: true,
-		shell : true
+    windowsHide: true
   })
 
   wget.on('error', (err) => {
@@ -88,10 +87,9 @@ function installLocal(PM2, module_filepath, opts, cb) {
 
     fs.mkdirSync(install_path, { recursive: true })
 
-    var install_instance = spawn('tar', ['zxf', module_filepath, '-C', install_path, '--strip-components 1'], {
+    var install_instance = spawn('tar', ['zxf', module_filepath, '-C', install_path, '--strip-components', '1'], {
       stdio : 'inherit',
-      env: process.env,
-		  shell : true
+      env: process.env
     })
 
     install_instance.on('close', function(code) {
@@ -254,10 +252,9 @@ function uninstall(PM2, module_name, cb) {
 function getModuleName(module_filepath, cb) {
   var tmp_folder = path.join(os.tmpdir(), cst.MODULE_BASEFOLDER)
 
-  var install_instance = spawn('tar', ['zxf', module_filepath, '-C', os.tmpdir(), `${cst.MODULE_BASEFOLDER}/package.json`], {
+  var install_instance = spawn('tar', ['zxf', module_filepath, '-C', os.tmpdir(), cst.MODULE_BASEFOLDER + '/package.json'], {
     stdio : 'inherit',
-    env: process.env,
-		shell : true
+    env: process.env
   })
 
   install_instance.on('close', function(code) {

lib/binaries/CLI.js

@@ -504,15 +504,15 @@ commander.command('install <module|git:// url>')
   .option('--safe [time]', 'keep module backup, if new module fail = restore with previous')
   .description('install or update a module and run it forever')
   .action(function(plugin_name, opts) {
-    require('util')._extend(commander, opts);
+    Object.assign(commander, opts);
     pm2.install(plugin_name, commander);
   });
 
 commander.command('module:update <module|git:// url>')
   .option('--tarball', 'is local tarball')
   .description('update a module and run it forever')
   .action(function(plugin_name, opts) {
-    require('util')._extend(commander, opts);
+    Object.assign(commander, opts);
     pm2.install(plugin_name, commander);
   });