add windows test + clear test separation between node.js and bun + shebang

Author: Unitech

.github/workflows/node.js.yml

@@ -10,7 +10,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [20, latest]
+        node-version: [20, 24]
 
     steps:
     - uses: actions/checkout@v4
@@ -25,3 +25,21 @@ jobs:
     - uses: actions/checkout@v4
     - name: Run parallel tests in Docker (Bun)
       run: RUNTIME=bun MAX_JOBS=6 npm run test:parallel
+
+  test-windows:
+    runs-on: windows-latest
+    timeout-minutes: 30
+
+    strategy:
+      matrix:
+        node-version: [20, latest]
+
+    steps:
+    - uses: actions/checkout@v4
+    - uses: actions/setup-node@v4
+      with:
+        node-version: ${{ matrix.node-version }}
+    - run: npm install
+    - name: Run tests (Node.js ${{ matrix.node-version }})
+      shell: bash
+      run: bash test/windows.sh

README.md

@@ -38,7 +38,7 @@ PM2 is constantly assailed by [more than 1800 tests](https://github.com/Unitech/
 
 Official website: [https://pm2.keymetrics.io/](https://pm2.keymetrics.io/)
 
-Works on Linux (stable) & macOS (stable) & Windows (stable). All Node.js versions are supported starting Node.js 12.X and Bun since v1
+Works on Linux (stable) & macOS (stable) & Windows (stable). All Node.js versions are supported starting Node.js 20.X and Bun since v1
 
 
 ## Installing PM2
@@ -54,7 +54,10 @@ $ npm install pm2 -g
 ```bash
 $ bun install pm2 -g
 ```
-**Please note that you might need to symlink node to bun if you only want to use bun via `sudo ln -s /home/$USER/.bun/bin/bun /usr/bin/node`**
+**If Node.js is not installed**, PM2 binaries use `#!/usr/bin/env node` as shebang, so you need to symlink `node` to `bun`:
+```bash
+$ sudo ln -s $(which bun) /usr/local/bin/node
+```
 
 ___
 

bin/pm2

@@ -1,3 +1,4 @@
-#!/usr/bin/env node
+#!/bin/sh
+':' //; exec "$(command -v node || command -v bun)" "$0" "$@"
 
 require('../lib/binaries/CLI.js');

bin/pm2-dev

@@ -1,3 +1,4 @@
-#!/usr/bin/env node
+#!/bin/sh
+':' //; exec "$(command -v node || command -v bun)" "$0" "$@"
 
 require('../lib/binaries/DevCLI.js');

bin/pm2-docker

@@ -1,3 +1,4 @@
-#!/usr/bin/env node
+#!/bin/sh
+':' //; exec "$(command -v node || command -v bun)" "$0" "$@"
 
 require('../lib/binaries/Runtime4Docker.js');

bin/pm2-runtime

@@ -1,3 +1,4 @@
-#!/usr/bin/env node
+#!/bin/sh
+':' //; exec "$(command -v node || command -v bun)" "$0" "$@"
 
 require('../lib/binaries/Runtime4Docker.js');

modules/pm2-io-agent/test/units/InteractorDaemon.mocha.js

@@ -424,7 +424,8 @@ describe('InteractorDaemon', () => {
         daemon.exit = _ => {
           assert(_startRPCCalled === 1)
           assert(daemon.opts.ROOT_URL === cst.KEYMETRICS_ROOT_URL)
-          assert(_processSendCalled === 1)
+          // Bun: sendToParent skips process.send when IS_BUN is true
+          if (typeof Bun === 'undefined') assert(_processSendCalled === 1)
           process.send = sendTmp
           axonMock.reset()
           cb()

package.json

@@ -106,7 +106,8 @@
     "test:bpm": "mocha 'modules/pm2-io-bpm/test/**/*.spec.js' --exit --timeout 10000",
     "test:axon-rpc": "mocha 'modules/pm2-axon-rpc/test/' --reporter spec --exit",
     "test:axon": "bash modules/pm2-axon/test/run modules/pm2-axon/test/test.*.js",
-    "test:io-agent": "mocha 'modules/pm2-io-agent/test/units/*.mocha.js' --reporter spec --exit"
+    "test:io-agent": "mocha 'modules/pm2-io-agent/test/units/*.mocha.js' --reporter spec --exit",
+    "test:windows": "bash test/windows.sh"
   },
   "keywords": [
     "cli",

test/Dockerfile

@@ -24,31 +24,39 @@ RUN apt-get update && apt-get install -y \
     gcc \
     && rm -rf /var/lib/apt/lists/*
 
-# Always install Node.js (required for PM2 daemon and tests)
-RUN mkdir -p /etc/apt/keyrings && \
-    curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
-    echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_${NODE_VERSION}.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list && \
-    apt-get update && \
-    apt-get install -y nodejs && \
-    rm -rf /var/lib/apt/lists/*
-
-# Additionally install Bun if RUNTIME=bun
+# Install Node.js when RUNTIME=node
+RUN if [ "$RUNTIME" = "node" ]; then \
+        mkdir -p /etc/apt/keyrings && \
+        curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
+        echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_${NODE_VERSION}.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list && \
+        apt-get update && \
+        apt-get install -y nodejs && \
+        rm -rf /var/lib/apt/lists/*; \
+    fi
+
+# Install Bun when RUNTIME=bun
 RUN if [ "$RUNTIME" = "bun" ]; then \
         curl -fsSL https://bun.sh/install | bash && \
         ln -s /root/.bun/bin/bun /usr/local/bin/bun && \
         ln -s /root/.bun/bin/bunx /usr/local/bin/bunx; \
     fi
 
-# Install mocha globally
-RUN npm install -g mocha
+# Install mocha globally (only needed for Node runtime)
+RUN if [ "$RUNTIME" = "node" ]; then \
+        npm install -g mocha; \
+    fi
 
 WORKDIR /var/pm2
 
 # Copy package files first (for layer caching)
 COPY package*.json ./
 
-# Install dependencies (always use npm for consistency)
-RUN npm install
+# Install dependencies
+RUN if [ "$RUNTIME" = "bun" ]; then \
+        bun install; \
+    else \
+        npm install; \
+    fi
 
 # Environment
 ENV PM2_DISCRETE_MODE=true

test/docker-parallel.sh

@@ -214,6 +214,15 @@ echo "[*] Found $TOTAL tests, running with $MAX_JOBS parallel jobs"
 [[ $SKIPPED -gt 0 ]] && echo "[*] Skipped $SKIPPED tests (require host features)"
 echo ""
 
+# Runtime commands (bunx mocha for Bun, mocha for Node)
+if [[ "$RUNTIME" == "bun" ]]; then
+    MOCHA="bunx mocha"
+    JSRUN="bun"
+else
+    MOCHA="mocha"
+    JSRUN="node"
+fi
+
 # Run a single test in a container (with isolated codebase copy)
 run_test() {
     local test_spec=$1
@@ -235,28 +244,28 @@ run_test() {
         cat "$CODEBASE_TAR" | docker run --rm -i \
             --mount type=tmpfs,destination=/root/.pm2 \
             "$IMAGE_NAME" \
-            bash -c "tar -xf - && mocha --exit --timeout 10000 --bail $test_path" \
+            bash -c "tar -xf - && $MOCHA --exit --timeout 10000 --bail $test_path" \
             > "$log_file" 2>&1
     elif [[ "$test_type" == "axon" ]]; then
-        # Axon: custom runner (runs test file with node directly)
+        # Axon: custom runner (runs test file directly)
         cat "$CODEBASE_TAR" | docker run --rm -i \
             "$IMAGE_NAME" \
-            bash -c "tar -xf - && node $test_path" \
+            bash -c "tar -xf - && $JSRUN $test_path" \
             > "$log_file" 2>&1
     elif [[ "$test_type" == "io-agent" ]] || [[ "$test_type" == "axon-rpc" ]]; then
         # IO Agent / Axon-RPC: mocha with spec reporter
         cat "$CODEBASE_TAR" | docker run --rm -i \
             --mount type=tmpfs,destination=/root/.pm2 \
             "$IMAGE_NAME" \
-            bash -c "tar -xf - && mocha --reporter spec --exit --bail $test_path" \
+            bash -c "tar -xf - && $MOCHA --reporter spec --exit --bail $test_path" \
             > "$log_file" 2>&1
     else
         # Unit: extract codebase, run with mocha
         # Use tmpfs for ~/.pm2 to speed up PM2 file I/O
         cat "$CODEBASE_TAR" | docker run --rm -i \
             --mount type=tmpfs,destination=/root/.pm2 \
             "$IMAGE_NAME" \
-            bash -c "tar -xf - && mocha --exit --bail $test_path" \
+            bash -c "tar -xf - && $MOCHA --exit --bail $test_path" \
             > "$log_file" 2>&1
     fi
 }