Silence cluster worker events to prevent boot crashes

Author: Unitech

CHANGELOG.md

@@ -4,6 +4,9 @@
 ### Bug Fixes
 
 - Fix `pm2 serve` returning 403 Forbidden on Windows — traversal guard used hardcoded `/` separator #6109
+- Silence cluster worker `error` events to prevent boot crashes
+- Wrap `process.send` before BPM injection to avoid send-on-disconnected during boot
+- BPM IPC transport: log instead of `process.exit(1)` on disconnected send
 
 
 ## 7.0.1

lib/ProcessContainer.js

@@ -9,6 +9,11 @@
  * - pid
  */
 
+var cluster = require('cluster');
+if (cluster.isWorker) {
+  cluster.worker.on('error', function () {});
+}
+
 var p       = require('path');
 var cst     = require('../constants');
 var Utility = require('./Utility.js');
@@ -36,6 +41,13 @@ delete process.env.pm2_env;
 (function ProcessContainer() {
   var fs          = require('fs');
 
+  var original_send = process.send;
+
+  process.send = function() {
+    if (process.connected)
+      original_send.apply(this, arguments);
+  };
+
   ProcessUtils.injectModules()
 
   var stdFile     = pm2_env.pm_log_path;
@@ -44,13 +56,6 @@ delete process.env.pm2_env;
   var pidFile     = pm2_env.pm_pid_path;
   var script      = pm2_env.pm_exec_path;
 
-  var original_send = process.send;
-
-  process.send = function() {
-    if (process.connected)
-      original_send.apply(this, arguments);
-  };
-
   //send node version
   if (process.versions && process.versions.node) {
     process.send({

lib/ProcessContainerBun.js

@@ -4,6 +4,11 @@
  * can be found in the LICENSE file.
  */
 
+var cluster = require('cluster');
+if (cluster.isWorker) {
+  cluster.worker.on('error', function () {});
+}
+
 var p       = require('path');
 var cst     = require('../constants');
 var Utility = require('./Utility.js');
@@ -31,6 +36,13 @@ delete process.env.pm2_env;
 (function ProcessContainer() {
   var fs          = require('fs');
 
+  var original_send = process.send;
+
+  process.send = function() {
+    if (process.connected)
+      original_send.apply(this, arguments);
+  };
+
   ProcessUtils.injectModules()
 
   var stdFile     = pm2_env.pm_log_path;
@@ -39,13 +51,6 @@ delete process.env.pm2_env;
   var pidFile     = pm2_env.pm_pid_path;
   var script      = pm2_env.pm_exec_path;
 
-  var original_send = process.send;
-
-  process.send = function() {
-    if (process.connected)
-      original_send.apply(this, arguments);
-  };
-
   //send node version
   if (process.versions && process.versions.node) {
     process.send({

modules/pm2-io-bpm/transports/IPCTransport.js

@@ -86,18 +86,15 @@ class IPCTransport extends EventEmitter {
 
   send (channel, payload) {
     if (typeof process.send !== 'function') return -1
-    if (process.connected === false) {
-      console.error('Process disconnected from parent! (not connected)')
-      return process.exit(1)
-    }
+    if (process.connected === false) return -1
 
+    this.logger(`Send on channel ${channel}`)
     try {
-      this.logger(`Send on channel ${channel}`)
-      process.send({ type: channel, data: payload })
+      process.send({ type: channel, data: payload }, (err) => {
+        if (err) this.logger('async send failed: %s', err && err.code)
+      })
     } catch (err) {
-      this.logger('Process disconnected from parent !')
-      this.logger(err)
-      return process.exit(1)
+      this.logger('Process disconnected from parent: %s', err && err.message)
     }
   }