PR feedback

Author: mtschoen-unity

Editor/ProxyFeedbackEditor.cs

@@ -8,7 +8,7 @@ namespace UnityEditor.Experimental.EditorVR.UI
 {
     sealed class ProxyFeedbackEditor : EditorWindow
     {
-        Dictionary<Type, SerializedProxyFeedback> m_SerializedFeedback = new Dictionary<Type, SerializedProxyFeedback>();
+        readonly Dictionary<Type, SerializedProxyFeedback> m_SerializedFeedback = new Dictionary<Type, SerializedProxyFeedback>();
         Vector2 m_Scroll;
 
         [MenuItem("Edit/Project Settings/EditorXR/Proxy Feedback")]

Scripts/Modules/SerializedPreferencesModule.cs

@@ -148,8 +148,8 @@ static void Deserialize(SerializedPreferences preferences, ISerializePreferences
             if (preferences.items.TryGetValue(serializer.GetType(), out item))
             {
                 var type = Type.GetType(item.payloadType);
-                if (type == null)
-                    return;
+                if (type == null)
+                    return;
 
                 var payload = JsonUtility.FromJson(item.payload, type);
                 serializer.OnDeserializePreferences(payload);

Scripts/Proxies/Data/SerializedProxyFeedback.cs

@@ -76,11 +76,11 @@ public override string ToString()
     [Serializable]
     class RequestData
     {
-        readonly Action m_OnBecameVisible;
-
         [SerializeField]
         int m_Presentations;
 
+        readonly Action m_OnBecameVisible;
+
         /// <summary>
         /// How many times the user viewed the presentation of this type of request
         /// </summary>