Fix exception if loading preferences for a type that doesn't exist

mtschoen-unity · mtschoen-unity · commit cd85c9dad313 · 2017-12-05T17:46:28.000-08:00
diff --git a/Scripts/Modules/SerializedPreferencesModule.cs b/Scripts/Modules/SerializedPreferencesModule.cs
@@ -147,7 +147,11 @@ static void Deserialize(SerializedPreferences preferences, ISerializePreferences
             SerializedPreferenceItem item;
             if (preferences.items.TryGetValue(serializer.GetType(), out item))
             {
-                var payload = JsonUtility.FromJson(item.payload, Type.GetType(item.payloadType));
+                var type = Type.GetType(item.payloadType);
+                if (type == null)
+                    return;
+
+                var payload = JsonUtility.FromJson(item.payload, type);
                 serializer.OnDeserializePreferences(payload);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,11 @@ static void Deserialize(SerializedPreferences preferences, ISerializePreferences`
`147`	`147`	`SerializedPreferenceItem item;`
`148`	`148`	`if (preferences.items.TryGetValue(serializer.GetType(), out item))`
`149`	`149`	`{`
`150`		`- var payload = JsonUtility.FromJson(item.payload, Type.GetType(item.payloadType));`
	`150`	`+ var type = Type.GetType(item.payloadType);`
	`151`	`+ if (type == null)`
	`152`	`+ return;`
	`153`	`+`
	`154`	`+ var payload = JsonUtility.FromJson(item.payload, type);`
`151`	`155`	`serializer.OnDeserializePreferences(payload);`
`152`	`156`	`}`
`153`	`157`	`}`