Merge pull request #8134 from Unity-Technologies/internal/6000.0/staging

Internal/6000.0/staging

Author: UnityAljosha

Packages/com.unity.render-pipelines.core/CHANGELOG.md

@@ -10,6 +10,66 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 Version Updated
 The version number for this package has increased due to a version update of a related graphics package.
 
+## [17.0.3] - 2025-02-13
+
+This version is compatible with Unity 6000.0.39f1.
+
+### Added
+- helper functions to Render Graph.
+
+### Changed
+- Improved the Native Render Pass CPU performance by implementing a Render Pass pooling system (URP RG).
+- Reworked the additional properties.
+- Improved Render Graph warning message in URP when missing RecordRenderGraph implementation.
+- Displayed subpass and attachment index on Render Graph Viewer.
+- Added a new icon and tooltip if there are multiple usage details for a resource block on Render Graph Viewer.
+- Fixed Render Graph Viewer being called before Render Graph execution and its resource deallocation.
+- Added What's New in Unity 6 to SRP Core Package.
+
+### Fixed
+- Added messaging to the Rendering Debugger UI to make it clearer that GPU Resident Drawer settings do not work if GPU Resident Drawer is not enabled. 
+- GPU Resident Drawer: Changed BatchRendererGroup variants was not reinitializing the system.
+- Improved the compiler logic that detects if the current render target is being used outside the current native render pass (e.g., when the pass is broken up by an unsafe pass), and determines the store action for this case. The fix now ensures that the `StoreAndResolve` action is used when the resource is read by an Unsafe Pass. 
+- Rendering Debugger - Keep the correct selected panel when entering and exiting from playmode.
+- Removed "depth only surface" warning message appearing when using Game View Gizmos in URP RG.
+- Render Graph Viewer: Fixed missing min height when resizing side panel vertical splitter.
+- Render Graph Viewer: Fixed possible NullReferenceException when opening the project.
+- Render Graph Viewer: Fixed side panel splitter state after returning from empty pass/resource filter.
+- Render Graph Viewer: Fixed long resource name clipping issues in side panel.
+- Render Graph Viewer: Fixed tooltip size bug and restructure tooltip messages.
+- Fixed memory usage regression causing up to 150MB higher memory usage in URP player builds.
+- Added missing user-facing text when inspecting volume profile when render pipeline has not been properly initialized yet.
+- Game view background turn yellow after enable render graph.
+- Fixed light.useViewFrustumForShadowCasterCull previously being ignored for shadow cascades. light.useViewFrustumForShadowCasterCull now works as expected.
+- Fixed an exception thrown when Render Graph pass was missing its renderFunc but tried to compute its hash value.
+- Fixed Render Graph Compiler logic bug where UnsafePass using MSAA texture could result in missing resolve surface errors.
+- Fixed incorrect default source texture name for Render Graph blit util function.
+- Fixed NullReferenceException when jumping to pass code from Render Graph Viewer.
+- Fixed _FOVEATED_RENDERING_NON_UNIFORM_RASTER shader compilation errors.
+- Fixed a null reference exception on the Graphics Settings stripper.
+- Avoid that the same volume can be registered more than 1 time in the VolumeManager.
+- Fixed crash caused by indirect argument buffer being one item too small.
+- [GLES3] Fixed an issue where Blitter.GetBlitMaterial(TextureDimension.Tex2DArray) returns null.
+- Fixed alignment of the columns on DebugUI.Foldouts.
+- Fixed BlitTexture(RenderTargetIdentifier) to be affected by PostProcessing.
+- Fixed errors that could happen when interacting with the Default Volume Profile context menu in Project Settings > Graphics.
+- Fixed a numerical error of ComputeEdgeFactor(V1, V2) when two vectors are colinear.
+- Fixed potential data corruption due to incorrect native render pass store action in NRP compiler.
+- Added stencil flag to read-only depth logic in NRP compiler to avoid unintentional usage of depth read and stencil write states on some APIs.
+- Added more error checking to `RenderGraph.ImportTexture` to prevent importing RenderTextures that have both color and depth.
+An exception will now be thrown in this case.
+- Fixed  an issue when using multiple AddBlitPass would binds the _BlitTexture wrongly.
+- Modified TextureDesc so it can now use GraphicsFormat to set the depthStencil format (TextureDesc.format). The TextureDesc.depthBufferBits and TextureDesc.colorFormat fields are now properties that call GraphicsFormatUtilities functions for backwards compatibility. The descriptor now unambiguously describes a single resource, either color or depth. Therefore, TextureHandle clearly represents a single resource.
+- Modified RTHandle allocators so they can now use GraphicsFormat to set the depthStencil format (TextureDesc.format). The allocators take a single format for either color or depth stencil to avoid incorrectly creating depth instead of color or vice versa.
+- Fixed a crash on DX12 due to invalid subpass flags passed by native render pass compiler.
+- Fixed an issue where Lens Flare was not rendering properly in OpenGLES3.
+- Fixed render graph incorrectly handling rendering to array slices and mipmaps other than 0 in some cases.
+- Render Graph Viewer - Improved UI lock when searching on side panels.
+- Render Graph Viewer - Padding corrected on burger menu on the side panels.
+- Fixed missing STP shaders & visual artifacts when targeting GLCore renderer
+- Rendering Debugger - Silent crash when selecting a Volume component with public RTHandles.
+- Fixed a crash on leaking streaming scratch buffer differently sized into the current pool.
+
 ## [17.0.2] - 2024-04-02
 
 This version is compatible with Unity 6000.0.0b15.

Packages/com.unity.render-pipelines.core/Editor/CoreEditorUtils.cs

@@ -863,7 +863,7 @@ static bool HandleEvent(bool state, Rect activationRect, Action<Vector2> context
             return state;
         }
 
-        static void ShowHelpButton(Rect contextMenuRect, string documentationURL, GUIContent title)
+        internal static void ShowHelpButton(Rect contextMenuRect, string documentationURL, GUIContent title)
         {
             if (string.IsNullOrEmpty(documentationURL))
                 return;

Packages/com.unity.render-pipelines.core/Editor/Debugging/DebugWindow.cs

@@ -11,7 +11,6 @@
 using UnityEngine;
 using UnityEngine.Assertions;
 using UnityEngine.Rendering;
-using PackageInfo = UnityEditor.PackageManager.PackageInfo;
 
 namespace UnityEditor.Rendering
 {
@@ -44,7 +43,8 @@ void OnEnable()
             hideFlags = HideFlags.HideAndDontSave;
         }
     }
-
+    
+    [CoreRPHelpURL("Rendering-Debugger")]
     sealed class DebugWindow : EditorWindowWithHelpButton, IHasCustomMenu
     {
         static Styles s_Styles;
@@ -76,37 +76,6 @@ public static bool open
             private set => DebugManager.instance.displayEditorUI = value;
         }
 
-        protected override void OnHelpButtonClicked()
-        {
-            //Deduce documentation url and open it in browser
-            var url = GetSpecificURL() ?? GetDefaultURL();
-            Application.OpenURL(url);
-        }
-
-        string GetDefaultURL()
-        {
-            //Find package info of the current CoreRP package
-            return $"https://docs.unity3d.com/Packages/com.unity.render-pipelines.core@{DocumentationInfo.version}/manual/Rendering-Debugger.html";
-        }
-
-        string GetSpecificURL()
-        {
-            //Find package info of the current RenderPipeline
-            var currentPipeline = GraphicsSettings.currentRenderPipeline;
-            if (currentPipeline == null)
-                return null;
-
-            if (!DocumentationUtils.TryGetPackageInfoForType(currentPipeline.GetType(), out var packageName, out var version))
-                return null;
-
-            return packageName switch
-            {
-                "com.unity.render-pipelines.universal" => $"https://docs.unity3d.com/Packages/com.unity.render-pipelines.universal@{version}/manual/features/rendering-debugger.html",
-                "com.unity.render-pipelines.high-definition" => $"https://docs.unity3d.com/Packages/com.unity.render-pipelines.high-definition@{version}/manual/Render-Pipeline-Debug-Window.html",
-                _ => null
-            };
-        }
-
         [DidReloadScripts]
         static void OnEditorReload()
         {
@@ -508,10 +477,23 @@ void OnGUI()
                 {
                     using (new EditorGUILayout.VerticalScope())
                     {
-                        const float leftMargin = 4f;
-                        GUILayout.Space(leftMargin);
                         var selectedPanel = panels[m_Settings.selectedPanel];
+                        
+                        using (new EditorGUILayout.HorizontalScope())
+                        {
+                            var style = new GUIStyle(CoreEditorStyles.sectionHeaderStyle) { fontStyle = FontStyle.Bold };
+                            EditorGUILayout.LabelField(new GUIContent(selectedPanel.displayName), style);
+                            
+                            // Context menu
+                            var rect = GUILayoutUtility.GetLastRect();
+                            var contextMenuRect = new Rect(rect.xMax, rect.y + 4f, 16f, 16f);
+                            
+                            CoreEditorUtils.ShowHelpButton(contextMenuRect, selectedPanel.documentationUrl, new GUIContent($"{selectedPanel.displayName} panel."));
+                        }
 
+                        const float leftMargin = 4f;
+                        GUILayout.Space(leftMargin);
+                        
                         using (var scrollScope = new EditorGUILayout.ScrollViewScope(m_ContentScroll))
                         {
                             TraverseContainerGUI(selectedPanel);

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.Serialization.cs

@@ -1031,7 +1031,7 @@ unsafe static void WriteBakingCells(BakingCell[] bakingCells)
             AssetDatabase.SaveAssets();
 
             // Explicitly make sure the binary output files are writable since we write them using the C# file API (i.e. check out Perforce files if applicable)
-            var outputPaths = new List<string>(new[] { cellDataFilename, cellBricksDataFilename, cellSharedDataFilename, cellSupportDataFilename, cellOptionalDataFilename });
+            var outputPaths = new List<string>(new[] { cellDataFilename, cellBricksDataFilename, cellSharedDataFilename, cellSupportDataFilename, cellOptionalDataFilename, cellProbeOcclusionDataFilename });
 
             if (!AssetDatabase.MakeEditable(outputPaths.ToArray()))
                 Debug.LogWarning($"Failed to make one or more probe volume output file(s) writable. This could result in baked data not being properly written to disk. {string.Join(",", outputPaths)}");

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeEditor.cs

@@ -123,7 +123,7 @@ internal static void FrameSettingDisabledHelpBox()
                 var k_EnsureFrameSetting = Type.GetType("UnityEditor.Rendering.HighDefinition.HDEditorUtils,Unity.RenderPipelines.HighDefinition.Editor")
                     .GetMethod("EnsureFrameSetting", BindingFlags.Static | BindingFlags.NonPublic);
 
-                k_EnsureFrameSetting.Invoke(null, new object[] { k_APVFrameSetting, "Adaptive Probe Volumes" });
+                k_EnsureFrameSetting.Invoke(null, new object[] { k_APVFrameSetting});
             }
         }
 

Packages/com.unity.render-pipelines.core/Editor/LookDev/EnvironmentLibrary.cs

@@ -12,7 +12,7 @@ namespace UnityEditor.Rendering.LookDev
     /// <summary>
     /// Class containing a collection of Environment
     /// </summary>
-    [CoreRPHelpURL("Environment-Library")]
+    [CoreRPHelpURL("Look-Dev-Environment-Library")]
     public class EnvironmentLibrary : ScriptableObject
     {
         [field: SerializeField]

Packages/com.unity.render-pipelines.core/Editor/RenderGraph/RenderGraphViewer.cs

@@ -3,6 +3,7 @@
 using UnityEditor.Rendering.Analytics;
 using UnityEditor.UIElements;
 using UnityEngine;
+using UnityEngine.Rendering;
 using UnityEngine.Rendering.RenderGraphModule;
 using UnityEngine.Scripting.APIUpdating;
 using UnityEngine.UIElements;
@@ -13,7 +14,8 @@ namespace UnityEditor.Rendering
     /// Editor window class for the Render Graph Viewer
     /// </summary>
     [MovedFrom("")]
-    public partial class RenderGraphViewer : EditorWindow
+    [CoreRPHelpURL(packageName: "com.unity.render-pipelines.universal", pageName: "render-graph-view")]
+    public partial class RenderGraphViewer : EditorWindowWithHelpButton
     {
         static partial class Names
         {

Packages/com.unity.render-pipelines.core/Runtime/Debugging/DebugDisplaySettingsUI.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Reflection;
 using UnityEngine.Rendering.RenderGraphModule;
 
 namespace UnityEngine.Rendering
@@ -51,6 +52,9 @@ public void RegisterDebug(IDebugDisplaySettings settings)
                     displayName: disposableSettingsPanel.PanelName,
                     createIfNull: true,
                     groupIndex: (disposableSettingsPanel is DebugDisplaySettingsPanel debugDisplaySettingsPanel) ? debugDisplaySettingsPanel.Order : 0);
+#if UNITY_EDITOR
+                panel.documentationUrl = disposableSettingsPanel.GetType().GetCustomAttribute<HelpURLAttribute>()?.URL;
+#endif
 
                 ObservableList<DebugUI.Widget> panelChildren = panel.children;
 

Packages/com.unity.render-pipelines.core/Runtime/Debugging/DebugUI.Panel.cs

@@ -53,6 +53,10 @@ public class Panel : IContainer, IComparable<Panel>
             /// Callback used when the panel is set dirty.
             /// </summary>
             public event Action<Panel> onSetDirty = delegate { };
+            
+#if UNITY_EDITOR
+            public string documentationUrl { get; set; }
+#endif
 
             /// <summary>
             /// Constructor.