Skip to content

Commit 1f84614

Browse files
rolandk-unityEvergreen
authored andcommitted
Fix Rendering Debugger going blank when search yields no results
1 parent 0330cb5 commit 1f84614

3 files changed

Lines changed: 11 additions & 0 deletions

File tree

Packages/com.unity.render-pipelines.core/Editor/Debugging/DebugWindow.SearchFilter.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,13 @@ sealed partial class DebugWindow
2929
readonly Dictionary<DebugUI.Widget, WidgetSearchData> m_WidgetSearchElementCache = new();
3030
readonly List<TextElement> m_PanelHeaderTextElements = new();
3131
UIElementSearchFilter m_SearchFilter;
32+
Label m_NoResultsLabel;
3233

3334
void BuildSearchCache()
3435
{
3536
m_WidgetSearchElementCache.Clear();
3637
m_PanelHeaderTextElements.Clear();
38+
m_NoResultsLabel = rootVisualElement.Q<Label>(name: "debug-window-no-results-label");
3739

3840
foreach (var panelElement in m_RightPaneElement.Children())
3941
{
@@ -76,6 +78,9 @@ void InitializeSearchField()
7678
tab.style.display = shouldShow ? DisplayStyle.Flex : DisplayStyle.None;
7779
}
7880
}
81+
82+
bool noResults = !string.IsNullOrEmpty(searchString) && visiblePanels.Count == 0;
83+
m_NoResultsLabel.style.display = noResults ? DisplayStyle.Flex : DisplayStyle.None;
7984
}
8085
);
8186
m_SearchFilter.InitializeSearchField("search-field");

Packages/com.unity.render-pipelines.core/Editor/Debugging/DebugWindow.uss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,3 +108,8 @@
108108
.info-button:hover {
109109
background-color: var(--unity-colors-button-background-hover);
110110
}
111+
112+
#debug-window-no-results-label {
113+
display: none;
114+
-unity-text-align: middle-center;
115+
}

Packages/com.unity.render-pipelines.core/Editor/Debugging/DebugWindow.uxml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<ui:VisualElement name="debug-window-tab-container" class="">
1616
<ui:ScrollView horizontal-scroller-visibility="Hidden" view-data-key="debug-window-tab-container-scrollview">
1717
<ui:VisualElement name="panels-inspector-insertion-element" />
18+
<ui:Label name="debug-window-no-results-label" text="No results match your search." />
1819
<ui:VisualElement name="scroll-buffer" />
1920
</ui:ScrollView>
2021
</ui:VisualElement>

0 commit comments

Comments
 (0)