SRP-266 Throw if AddRenderPass is used with NRP

Author: RoseHirigoyen

Packages/com.unity.render-pipelines.core/Runtime/RenderGraph/Compiler/NativePassCompiler.cs

@@ -151,8 +151,8 @@ void BuildGraph()
                     if (inputPass.type == RenderGraphPassType.Legacy)
                     {
                         throw new Exception("Pass '" + inputPass.name + "' is using the legacy rendergraph API." +
-                                            " You cannot use legacy passes with the native render pass compiler." +
-                                            " Please do not use AddPass on the rendergraph but use one of the more specific pass types such as AddRasterRenderPass");
+                                            " You cannot use legacy passes with the Native Render Pass Compiler." +
+                                            " The APIs that are compatible with the Native Render Pass Compiler are AddUnsafePass, AddComputePass and AddRasterRenderPass.");
                     }
 #endif
 

Packages/com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraph.cs

@@ -592,7 +592,7 @@ internal void ForceCleanup()
             nativeCompiler?.Cleanup();
 
             m_CompilationCache?.Clear();
-            
+
             DelegateHashCodeUtils.ClearCache();
         }
 
@@ -1165,6 +1165,17 @@ void CheckNotUsedWhenRecordingPass()
                 throw new InvalidOperationException(RenderGraphExceptionMessages.GetExceptionMessage(RenderGraphState.RecordingPass));
         }
 
+        [Conditional("DEVELOPMENT_BUILD"), Conditional("UNITY_EDITOR")]
+        void CheckNotUsingNativeRenderPassCompiler()
+        {
+            if (enableValidityChecks && nativeRenderPassesEnabled)
+            {
+                throw new InvalidOperationException(
+                    "`AddRenderPass` is not compatible with the Native Render Pass Compiler. It is meant to be used with the HDRP Compiler. " +
+                    "The APIs that are compatible with the Native Render Pass Compiler are AddUnsafePass, AddComputePass and AddRasterRenderPass.");
+            }
+        }
+
         [Conditional("DEVELOPMENT_BUILD"), Conditional("UNITY_EDITOR")]
         void CheckNotUsedWhenActive()
         {
@@ -1368,11 +1379,12 @@ public RenderGraphBuilder AddRenderPass<PassData>(string passName, out PassData
             [CallerLineNumber] int line = 0) where PassData : class, new()
 #endif
         {
+            CheckNotUsingNativeRenderPassCompiler();
             CheckNotUsedWhenRecordingPass();
 
             m_RenderGraphState = RenderGraphState.RecordingPass;
 
-            var renderPass = m_RenderGraphPool.Get<RenderGraphPass<PassData>>();          
+            var renderPass = m_RenderGraphPool.Get<RenderGraphPass<PassData>>();
             renderPass.Initialize(m_RenderPasses.Count, m_RenderGraphPool.Get<PassData>(), passName, RenderGraphPassType.Legacy, sampler);
             renderPass.AllowGlobalState(true);// Old pass types allow global state by default as HDRP relies on it