Provide a way for Surface Cache to be considered when stripping the meta pass from builds

Author: laylaarab

Packages/com.unity.render-pipelines.universal/Editor/BuildProcessors/GraphicsSettingsStrippers/SurfaceCacheGIStripper.cs

@@ -10,25 +10,32 @@ namespace UnityEditor.Rendering
 {
     static class SurfaceCacheStripperUtility
     {
-        static bool IsSurfaceCacheEnabled(List<UniversalRenderPipelineAsset> urpAssets)
+        static bool IsSurfaceCacheEnabled(UniversalRenderPipelineAsset urpAsset)
         {
-            foreach (var urpAssetForBuild in urpAssets)
+            foreach (var rendererData in urpAsset.m_RendererDataList)
             {
-                foreach (var rendererData in urpAssetForBuild.m_RendererDataList)
+                if(rendererData is not UniversalRendererData)
+                    continue;
+
+                foreach (var rendererFeature in rendererData.rendererFeatures)
                 {
-                    if(rendererData is not UniversalRendererData)
-                        continue;
-
-                    foreach (var rendererFeature in rendererData.rendererFeatures)
-                    {
-                        if (rendererFeature is SurfaceCacheGIRendererFeature { isActive: true })
-                            return true;
-                    }
+                    if (rendererFeature is SurfaceCacheGIRendererFeature { isActive: true })
+                        return true;
                 }
             }
             return false;
         }
 
+        static bool IsSurfaceCacheEnabled(List<UniversalRenderPipelineAsset> urpAssets)
+        {
+            foreach (var urpAssetForBuild in urpAssets)
+            {
+                if (IsSurfaceCacheEnabled(urpAssetForBuild))
+                    return true;
+            }
+            return false;
+        }
+
         internal static bool CanRemoveSurfaceCacheSettings(List<UniversalRenderPipelineAsset> urpAssets)
         {
             if (GraphicsSettings.TryGetRenderPipelineSettings<URPShaderStrippingSetting>(out var urpShaderStrippingSettings) && !urpShaderStrippingSettings.stripUnusedVariants)
@@ -39,6 +46,26 @@ internal static bool CanRemoveSurfaceCacheSettings(List<UniversalRenderPipelineA
 
             return true;
         }
+
+        // Required by native side for meta pass stripping.
+        [UnityEngine.Scripting.Preserve]
+        internal static bool IsSurfaceCacheEnabledForBuild()
+        {
+            // Check if we're building with URP and if Surface Cache is enabled in the build assets
+            if (URPBuildData.instance.buildingPlayerForUniversalRenderPipeline)
+            {
+                return IsSurfaceCacheEnabled(URPBuildData.instance.renderPipelineAssets);
+            }
+
+            // Fallback to current render pipeline asset if not in a build context
+            var currentRP = UnityEngine.Rendering.GraphicsSettings.currentRenderPipeline;
+            if (currentRP is UniversalRenderPipelineAsset urpAsset)
+            {
+                return IsSurfaceCacheEnabled(urpAsset);
+            }
+
+            return false;
+        }
     }
 
     class UniversalSurfaceCacheIntegrationStripper : IRenderPipelineGraphicsSettingsStripper<UnityEngine.Rendering.Universal.SurfaceCacheRenderPipelineResourceSet>

Packages/com.unity.render-pipelines.universal/Editor/ShaderScriptableStripper.cs

@@ -1088,13 +1088,13 @@ internal bool StripUnusedPass_2D(ref IShaderScriptableStrippingData strippingDat
 
         internal bool StripUnusedPass_Meta(ref IShaderScriptableStrippingData strippingData)
         {
-            // Meta pass is needed in the player for Enlighten Precomputed Realtime GI albedo and emission.
+            // Meta pass is needed for Enlighten and Surface Cache realtime GI systems.
             if (strippingData.passType == PassType.Meta)
             {
                 if (SupportedRenderingFeatures.active.enlighten == false
-                    || ((int)SupportedRenderingFeatures.active.lightmapBakeTypes | (int)LightmapBakeType.Realtime) == 0
+                    && ((int)SupportedRenderingFeatures.active.lightmapBakeTypes | (int)LightmapBakeType.Realtime) == 0
 #if SURFACE_CACHE
-                    || !strippingData.IsShaderFeatureEnabled(ShaderFeatures.SurfaceCache)
+                    && !strippingData.IsShaderFeatureEnabled(ShaderFeatures.SurfaceCache)
 #endif
                    )
                     return true;