Merge pull request #8147 from Unity-Technologies/internal/master

Internal/master

Author: UnityAljosha

Packages/com.unity.render-pipelines.core/Documentation~/Images/LightAnchorAnimation.gif

@@ -127,7 +127,7 @@ public class CustomDebugPanel : MonoBehaviour
 
 Add the script to a GameObject. You should see a new **My Custom Panel** panel in the **Rendering Debugger** window.
 
-![](Images/rendering-debugger.png)
+![Screenshot of the Rendering Debugger window showing a new custom panel.](Images/rendering-debugger.png)
 
 ### Add a control to an existing panel
 

Packages/com.unity.render-pipelines.core/Documentation~/Images/videos/light-anchor-animation.mp4

@@ -17,13 +17,13 @@ Use the **Orbit** and **Elevation** to control the orientation of the light, in
 
 You can use the **Anchor Position Override** to provide a GameObject’s [Transform](https://docs.unity3d.com/ScriptReference/Transform.html) as an anchor point for the Light. This is useful if you want the Light to follow a specific GameObject in the Scene.
 
-![](Images/LightAnchorAnimation.gif)
+<video title="A light uses the main camera as the reference GamObject that controls the rotation of the light. The light rotates synchronously with the camera." src="Images/videos/light-anchor-animation.mp4" width="100%" height="auto" autoplay="true" loop="true" controls></video>
 
 **Note**: The above example uses the Main Camera as the reference Camera that adjusts the light rotation. The Common presets might create a different result in the Scene View if your view isn't aligned with the Main Camera.
 
 You can set a **Position Offset** for this custom Anchor. This is useful if the Transform position of the custom Anchor isn't centered appropriately for the light to orbit correctly around the custom Anchor.
 
-![](Images/LightAnchor0.png)
+![Light Anchor component screenshot. Orbit and Elevation properties display example values that change the orientation of a light.](Images/LightAnchor0.png)
 
 
 The Light Anchor component also includes a list of **Presets** that you can use to set the Light's orientation relative to the main Camera.

Packages/com.unity.render-pipelines.core/Documentation~/Rendering-Debugger.md

@@ -37,7 +37,7 @@ public class MySettings : IRenderPipelineGraphicsSettings
   public Material myMaterial;
 }
 ```
-![](Images/customsettings-addsetting.png)<br/>
+![Screenshot of the Project Settings window. The Graphics section contains the new custom settings from the example script.](Images/customsettings-addsetting.png)<br/>
 The **Edit** > **Project Settings** > **Graphics** window with the new custom setting from the example script.
 
 ## Set the default asset for a reference property

Packages/com.unity.render-pipelines.core/Documentation~/View-Lighting-Tool.md

@@ -37,7 +37,7 @@ public class MySettings : IRenderPipelineGraphicsSettings
 }
 ```
 
-![](Images/customsettings-settingsgroup.png)<br/>
+![Screenshot of the Project Settings window. The Graphics section contains the new custom settings group from the example script.](Images/customsettings-settingsgroup.png)<br/>
 The **Edit** > **Project Settings** > **Graphics** window with the new custom settings group from the example script.
 
 ## Change the display order of settings groups

Packages/com.unity.render-pipelines.core/Documentation~/add-custom-graphics-setting.md

@@ -30,4 +30,4 @@ For example:
 
 Unity shows the new properties in the **Core Render Pipeline** settings section:
 
-![](Images/core_render_pipeline_preference_provider.png)
+![Screenshot of the Preferences window showing the new properties in the Core Render Pipeline settings section.](Images/core_render_pipeline_preference_provider.png)

Packages/com.unity.render-pipelines.core/Documentation~/add-custom-graphics-settings.md

@@ -3,3 +3,6 @@
 [assembly: InternalsVisibleTo("Unity.RenderPipelines.Core.Editor.Shared")]
 [assembly: InternalsVisibleTo("Unity.RenderPipelines.Core.Editor.Tests")]
 [assembly: InternalsVisibleTo("Unity.RenderPipelines.HighDefinition.Editor.Tests")]
+[assembly: InternalsVisibleTo("Unity.RenderPipelines.HighDefinition.Editor.Tests")]
+[assembly: InternalsVisibleTo("Assembly-CSharp-Editor-testable")]
+

Packages/com.unity.render-pipelines.core/Documentation~/adding-properties.md

@@ -215,7 +215,7 @@ static CoreEditorStyles()
             greenTexture = CoreEditorUtils.CreateColoredTexture2D(Color.green, "Green 1x1");
             blueTexture = CoreEditorUtils.CreateColoredTexture2D(Color.blue, "Blue 1x1");
 
-            iconHelp = CoreEditorUtils.FindTexture("_Help");
+            iconHelp = CoreEditorUtils.LoadIcon("icons", "console.infoicon", ".png");
             iconWarn = CoreEditorUtils.LoadIcon("icons", "console.warnicon", ".png");
             iconFail = CoreEditorUtils.LoadIcon("icons", "console.erroricon", ".png");
             iconSuccess = EditorGUIUtility.FindTexture("TestPassed");

Packages/com.unity.render-pipelines.core/Editor/AssemblyInfo.cs

@@ -1 +1 @@
-area: Post-processing and UI Features
+area: Post-processing and Compositing