[HDRP] Migrated performance warning platform check from HDRP package code to engine-side.

Author: EmreDoganUnity

Packages/com.unity.render-pipelines.high-definition/Editor/BuildProcessors/HDRPPreprocessBuild.cs

@@ -146,6 +146,13 @@ public override void OnInspectorGUI()
             }
             m_SerializedProperties.Update();
 
+            if (EditorGraphicsSettings.ShouldValidateGraphicsForActiveBuildTarget())
+            {
+                var validationSettings = HDProjectSettings.validationSettings;
+                if (!validationSettings.k_GraphicsCompositor_Recommended && m_compositionManager.enableInternal)
+                    HDEditorUtils.ShowFeatureOptimisationWarning("Graphics Compositor");
+            }
+
             m_EnablePreview = EditorGUILayout.Toggle(Styles.k_EnablePreview, m_compositionManager.enableOutput);
             {
                 m_compositionManager.enableOutput = m_EnablePreview;

Packages/com.unity.render-pipelines.high-definition/Editor/Compositor/CompositionManagerEditor.cs

@@ -519,9 +519,35 @@ public override void OnInspectorGUI()
             }
             using var disableScope = new EditorGUI.DisabledScope(notSupported);
 
+            if (EditorGraphicsSettings.ShouldValidateGraphicsForActiveBuildTarget())
+            {
+                var validationSettings = HDProjectSettings.validationSettings;
+                VolumetricClouds defaultClouds = HDEditorUtils.GetVolumeComponentDefaultState<VolumetricClouds>();
+
+                // Get effective quality value (use local if overridden, otherwise use default)
+                bool useDefaultEnabled = !m_Enable.overrideState.boolValue;
+                bool effectiveEnabled = useDefaultEnabled
+                    ? (defaultClouds?.enable.value ?? false)
+                    : m_Enable.value.boolValue;
+
+                if (effectiveEnabled && !validationSettings.k_VolumetricClouds_Recommended)
+                {
+                    if (useDefaultEnabled && HDEditorUtils.TryGetVolumeParameterSource<VolumetricClouds>(
+                      clouds => clouds.enable.overrideState && clouds.enable.value == effectiveEnabled,
+                      out var sourceProfile,
+                      out var sourceName))
+                    {
+                        HDEditorUtils.ShowFeatureOptimisationWarning(HDRenderPipelineUI.Styles.volumetricCloudsSubTitle.text, sourceName, () => Selection.activeObject = sourceProfile);
+                    }
+                    else
+                    {
+                        HDEditorUtils.ShowFeatureOptimisationWarning(HDRenderPipelineUI.Styles.volumetricCloudsSubTitle.text);
+                    }
+                }
+            }
+
             EditorGUILayout.LabelField("General", EditorStyles.miniLabel);
             PropertyField(m_Enable, EditorGUIUtility.TrTextContent("State"));
-
             if (m_Enable.value.boolValue && !notSupported)
                 HDEditorUtils.EnsureFrameSetting(FrameSettingsField.VolumetricClouds);
 

Packages/com.unity.render-pipelines.high-definition/Editor/Lighting/VolumetricClouds/VolumetricCloudsEditor.cs

@@ -25,31 +25,35 @@ public override void OnInspectorGUI()
         {
             HDEditorUtils.EnsureFrameSetting(FrameSettingsField.FilmGrain);
 
-            var defaultFilmGrain = HDEditorUtils.GetVolumeComponentDefaultState<FilmGrain>();
+            if (EditorGraphicsSettings.ShouldValidateGraphicsForActiveBuildTarget())
+            {
+                var defaultFilmGrain = HDEditorUtils.GetVolumeComponentDefaultState<FilmGrain>();
 
-            // Get effective intensity value (use local if overridden, otherwise use default)
-            bool useDefaultIntensity = !m_Intensity.overrideState.boolValue;
-            float effectiveIntensity = useDefaultIntensity
-                ? (defaultFilmGrain?.intensity.value ?? -1.0f)
-                : m_Intensity.value.floatValue;
+                // Get effective intensity value (use local if overridden, otherwise use default)
+                bool useDefaultIntensity = !m_Intensity.overrideState.boolValue;
+                float effectiveIntensity = useDefaultIntensity
+                    ? (defaultFilmGrain?.intensity.value ?? 0.0f)
+                    : m_Intensity.value.floatValue;
 
-            if (effectiveIntensity > 0.0f)
-            {
-                using (new IndentLevelScope())
+                var validationSettings = HDProjectSettings.validationSettings;
+                if (effectiveIntensity > 0.0f && !validationSettings.k_FilmGrain_Recommended)
                 {
-                    if (useDefaultIntensity && HDEditorUtils.TryGetVolumeParameterSource<FilmGrain>(
-                          filmGrain => filmGrain.intensity.overrideState && filmGrain.intensity.value > 0.0f,
-                          out var sourceProfile,
-                          out var sourceName))
-                    {
-                        HDEditorUtils.ShowPlatformPerformanceWarning(BuildTarget.Switch2, "Film Grain", sourceName, () => Selection.activeObject = sourceProfile);
-                    }
-                    else
+                    using (new IndentLevelScope())
                     {
-                        HDEditorUtils.ShowPlatformPerformanceWarning(BuildTarget.Switch2, "Film Grain");
+                        if (useDefaultIntensity && HDEditorUtils.TryGetVolumeParameterSource<FilmGrain>(
+                              filmGrain => filmGrain.intensity.overrideState && filmGrain.intensity.value > 0.0f,
+                              out var sourceProfile,
+                              out var sourceName))
+                        {
+                            HDEditorUtils.ShowFeatureOptimisationWarning("Film Grain", sourceName, () => Selection.activeObject = sourceProfile);
+                        }
+                        else
+                        {
+                            HDEditorUtils.ShowFeatureOptimisationWarning("Film Grain");
+                        }
                     }
-                }
-            }
+
+                }            }
 
             PropertyField(m_Type);
 

Packages/com.unity.render-pipelines.high-definition/Editor/PostProcessing/FilmGrainEditor.cs

@@ -498,26 +498,19 @@ internal static bool TryGetVolumeParameterSource<T>(
         /// <summary>
         /// Shows a platform-specific performance warning help box for a given feature.
         /// </summary>
-        /// <param name="targetPlatform">The build target platform to check and display</param>
         /// <param name="featureName">The name of the feature (e.g., "Ray Tracing", "Film Grain")</param>
         /// <param name="recommendation">Optional recommendation text. If null, uses default "is not recommended for this platform"</param>
-        internal static void ShowPlatformPerformanceWarning(BuildTarget targetPlatform, string featureName, string recommendation = null)
+        internal static void ShowFeatureOptimisationWarning(string featureName, string recommendation = null)
         {
-            if (EditorUserBuildSettings.activeBuildTarget != targetPlatform)
-                return;
-
-            var activeBuildTargetGroup = BuildPipeline.GetBuildTargetGroup(targetPlatform);
-            var namedBuildTarget = NamedBuildTarget.FromBuildTargetGroup(activeBuildTargetGroup);
-
-            string message = $"{featureName} is enabled for {namedBuildTarget.TargetName}. ";
+            string message = $"{featureName} is enabled for the active platform.\n";
 
             if (!string.IsNullOrEmpty(recommendation))
             {
                 message += recommendation;
             }
             else
             {
-                message += "\nThis may significantly impact performance and is not recommended for this platform.";
+                message += HDRenderPipelineUI.Styles.featureNotRecommendedWarning;
             }
 
             EditorGUILayout.HelpBox(message, MessageType.Warning, wide: true);
@@ -526,26 +519,19 @@ internal static void ShowPlatformPerformanceWarning(BuildTarget targetPlatform,
         /// <summary>
         /// Shows a platform-specific performance warning help box for a given feature.
         /// </summary>
-        /// <param name="targetPlatform">The build target platform to check and display</param>
         /// <param name="featureName">The name of the feature (e.g., "Ray Tracing", "Film Grain")</param>
         /// <param name="recommendation">Optional recommendation text. If null, uses default "is not recommended for this platform"</param>
-        internal static void ShowPlatformPerformanceWarning(BuildTarget targetPlatform, string featureName, string sourceAssetName, Action onButtonClicked, string recommendation = null)
+        internal static void ShowFeatureOptimisationWarning(string featureName, string sourceAssetName, Action onButtonClicked, string recommendation = null)
         {
-            if (EditorUserBuildSettings.activeBuildTarget != targetPlatform)
-                return;
-
-            var activeBuildTargetGroup = BuildPipeline.GetBuildTargetGroup(targetPlatform);
-            var namedBuildTarget = NamedBuildTarget.FromBuildTargetGroup(activeBuildTargetGroup);
-
-            string message = $"{featureName} is enabled in {sourceAssetName} for {namedBuildTarget.TargetName}. ";
+            string message = $"{featureName} is enabled in {sourceAssetName} for the active platform.\n";
 
             if (!string.IsNullOrEmpty(recommendation))
             {
                 message += recommendation;
             }
             else
             {
-                message += "\nThis may significantly impact performance and is not recommended for this platform.";
+                message += HDRenderPipelineUI.Styles.featureNotRecommendedWarning;
             }
 
             CoreEditorUtils.DrawFixMeBox(
@@ -555,54 +541,32 @@ internal static void ShowPlatformPerformanceWarning(BuildTarget targetPlatform,
                 onButtonClicked);
         }
 
-        /// <summary>
-        /// Shows a platform-specific performance warning help box for a given setting within a feature.
-        /// </summary>
-        /// <param name="targetPlatform">The build target platform to check and display</param>
-        /// <param name="settingName">The name of the setting responsible for the performance warning in the feature.</param>
-        /// <param name="settingValue">The current value of the setting.</param>
-        /// <param name="recommendation">Optional recommendation text. If null, uses default "is not recommended for this platform"</param>
-        internal static void ShowPlatformParameterPerformanceWarning(BuildTarget targetPlatform, string settingName, string settingValue, string recommendation = null)
+        internal static void ShowFeatureParameterOptimisationWarning(string settingName, string settingValue, string recommendation = null)
         {
-            if (EditorUserBuildSettings.activeBuildTarget != targetPlatform)
-                return;
-
-            var activeBuildTargetGroup = BuildPipeline.GetBuildTargetGroup(targetPlatform);
-            var namedBuildTarget = NamedBuildTarget.FromBuildTargetGroup(activeBuildTargetGroup).TargetName;
+            EditorGUILayout.HelpBox(CreateParameterWarningMessage(settingName, settingValue, null, recommendation), MessageType.Warning, wide: true);
+        }
 
-            string message = $"{settingName}: {settingValue} is used for {namedBuildTarget}.";
+        internal static void ShowFeatureParameterOptimisationWarning(string settingName, string settingValue, string sourceAssetName, Action onButtonClicked, string recommendation = null)
+        {
+            CoreEditorUtils.DrawFixMeBox(
+                CreateParameterWarningMessage(settingName, settingValue, sourceAssetName, recommendation),
+                MessageType.Warning,
+                "Open",
+                onButtonClicked);
+        }
 
-            if (!string.IsNullOrEmpty(recommendation))
+        internal static string CreateParameterWarningMessage(string settingName, string settingValue, string sourceAssetName = null, string recommendation = null)
+        {
+            string message = $"{settingName}: {settingValue} ";
+            if (sourceAssetName != null)
             {
-                message += '\n' + recommendation;
+                message += $"is set in {sourceAssetName}.";
             }
             else
             {
-                message += "\nThis may significantly impact performance and is not recommended for this platform.";
+                message += $"is used for the active platform.";
             }
 
-            EditorGUILayout.HelpBox(message, MessageType.Warning, wide: true);
-        }
-
-        /// <summary>
-        /// Shows a platform-specific performance warning help box for a given setting within a feature.
-        /// </summary>
-        /// <param name="targetPlatform">The build target platform to check and display</param>
-        /// <param name="settingName">The name of the setting responsible for the performance warning in the feature.</param>
-        /// <param name="settingValue">The current value of the setting.</param>
-        /// <param name="sourceAssetName">The name of the asset responsible for producing this warning.</param>
-        /// <param name="onButtonClicked">Action to perform when the helpbox button is clicked.</param>
-        /// <param name="recommendation">Optional recommendation text. If null, uses default "is not recommended for this platform"</param>
-        internal static void ShowPlatformParameterPerformanceWarning(BuildTarget targetPlatform, string settingName, string settingValue, string sourceAssetName, Action onButtonClicked, string recommendation = null)
-        {
-            if (EditorUserBuildSettings.activeBuildTarget != targetPlatform)
-                return;
-
-            var activeBuildTargetGroup = BuildPipeline.GetBuildTargetGroup(targetPlatform);
-            var namedBuildTarget = NamedBuildTarget.FromBuildTargetGroup(activeBuildTargetGroup).TargetName;
-
-            string message = $"{settingName}: {settingValue} is set in {sourceAssetName} for {namedBuildTarget}. ";
-
             if (!string.IsNullOrEmpty(recommendation))
             {
                 message += '\n' + recommendation;
@@ -612,11 +576,7 @@ internal static void ShowPlatformParameterPerformanceWarning(BuildTarget targetP
                 message += $"\nThis may impact performance and is not recommended for this platform.";
             }
 
-            CoreEditorUtils.DrawFixMeBox(
-                message,
-                MessageType.Warning,
-                "Open",
-                onButtonClicked);
+            return message;
         }
 
         internal static bool IsInTestSuiteOrBatchMode()

Packages/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/HDEditorUtils.cs

@@ -422,6 +422,10 @@ int CountBits(uint bitMask) // System.Numerics.BitOperations not available
             public static GUIContent staticBatchingInfoMessage =
                 EditorGUIUtility.TrTextContent("Static Batching is not recommended when using GPU draw submission modes, performance may improve if Static Batching is disabled in Player Settings.");
 
+            public static readonly string featureNotRecommendedWarning = L10n.Tr("This feature is not optimized for this platform, enabling it may affect performance.");
+            public static readonly string maxFogBudgetWarning = L10n.Tr("The maximum recommended fog budget for this platform is {0}. Lower the tier to stay under this for optimal performance.");
+            public static readonly string minFogBudgetForDensityCutoffWarning = L10n.Tr("It is recommended to use Density cutoff when the fog budget is > {0} for this platform.");
+
             public const string memoryDrawback = "Adds GPU memory";
             public const string shaderVariantDrawback = "Adds Shader Variants";
             public const string lotShaderVariantDrawback = "Adds multiple Shader Variants";

Packages/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/HDRenderPipelineUI.Skin.cs

@@ -230,6 +230,13 @@ static void Drawer_Volumetric(SerializedHDRenderPipelineAsset serialized, Editor
             }
 
             EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportVolumetricClouds, Styles.supportVolumetricCloudsContent);
+
+            if (EditorGraphicsSettings.ShouldValidateGraphicsForActiveBuildTarget())
+            {
+                var validationSettings = HDProjectSettings.validationSettings;
+                if (serialized.renderPipelineSettings.supportVolumetricClouds.boolValue && !validationSettings.k_VolumetricClouds_Recommended)
+                    HDEditorUtils.ShowFeatureOptimisationWarning(Styles.volumetricCloudsSubTitle.text);
+            }
         }
 
         static void Drawer_SectionProbeVolume(SerializedHDRenderPipelineAsset serialized, Editor owner)
@@ -1231,6 +1238,13 @@ static void Drawer_SectionHighQualityLineRenderingSettings(SerializedHDRenderPip
         {
             EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportHighQualityLineRendering, Styles.supportHighQualityLineRenderingContent);
 
+            if (EditorGraphicsSettings.ShouldValidateGraphicsForActiveBuildTarget())
+            {
+                var validationSettings = HDProjectSettings.validationSettings;
+                if (serialized.renderPipelineSettings.supportHighQualityLineRendering.boolValue && !validationSettings.k_HighQualityLineRendering_Recommended)
+                    HDEditorUtils.ShowFeatureOptimisationWarning(Styles.highQualityLineRenderingSubTitle.text);
+            }
+
             ++EditorGUI.indentLevel;
             using (new EditorGUI.DisabledScope(!serialized.renderPipelineSettings.supportHighQualityLineRendering.boolValue))
             {
@@ -1448,7 +1462,7 @@ static void DrawSSGIQualitySetting(SerializedHDRenderPipelineAsset serialized, i
         internal static void DisplayRayTracingSupportBox()
         {
             var currentBuildTarget = EditorUserBuildSettings.activeBuildTarget;
-            if (HDRenderPipeline.PlatformHasRaytracingIssues(currentBuildTarget, out var warning))
+            if (HDRenderPipeline.CheckPlatformRaytracingCompatability(currentBuildTarget, out var warning))
             {
                 EditorGUILayout.HelpBox(warning, MessageType.Warning);
             }
@@ -1604,8 +1618,13 @@ static void Drawer_SectionMaterialUnsorted(SerializedHDRenderPipelineAsset seria
             EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportDistortion, Styles.supportDistortion);
 
             EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportSubsurfaceScattering, Styles.supportedSSSContent);
-            if (serialized.renderPipelineSettings.supportSubsurfaceScattering.boolValue)
-                HDEditorUtils.ShowPlatformPerformanceWarning(BuildTarget.Switch2, "Subsurface Scattering");
+
+            if (EditorGraphicsSettings.ShouldValidateGraphicsForActiveBuildTarget())
+            {
+                var validationSettings = HDProjectSettings.validationSettings;
+                if (serialized.renderPipelineSettings.supportSubsurfaceScattering.boolValue && !validationSettings.k_SubsurfaceScattering_Recommended)
+                    HDEditorUtils.ShowFeatureOptimisationWarning(Styles.supportedSSSContent.text);
+            }
 
             using (new EditorGUI.DisabledScope(serialized.renderPipelineSettings.supportSubsurfaceScattering.hasMultipleDifferentValues
                 || !serialized.renderPipelineSettings.supportSubsurfaceScattering.boolValue))