Fix empty shadowmap not being cleared in URP on console platforms

Author: laylaarab

Packages/com.unity.render-pipelines.universal/Runtime/Passes/AdditionalLightsShadowCasterPass.cs

@@ -62,6 +62,8 @@ public ShadowResolutionRequest(int _visibleLightIndex, int _perLightShadowSliceI
         internal RTHandle m_AdditionalLightsShadowmapHandle;
 
         private bool m_CreateEmptyShadowmap;
+        private bool m_EmptyShadowmapNeedsClear = false;
+
         private RTHandle m_EmptyAdditionalLightShadowmapTexture;
         private const int k_EmptyShadowMapDimensions = 1;
         private const string k_AdditionalLightShadowMapTextureName = "_AdditionalLightsShadowmapTexture";
@@ -142,7 +144,8 @@ public AdditionalLightsShadowCasterPass(RenderPassEvent evt)
                 m_ShadowResolutionRequests.Capacity = maxVisibleAdditionalLights;
             }
 
-            m_EmptyAdditionalLightShadowmapTexture = RTHandles.Alloc(Texture2D.blackTexture);
+            m_EmptyAdditionalLightShadowmapTexture = ShadowUtils.AllocShadowRT(1, 1, k_ShadowmapBufferBits, 1, 0, name: "_EmptyAdditionalLightShadowmapTexture");
+            m_EmptyShadowmapNeedsClear = true;
         }
 
         /// <summary>
@@ -151,6 +154,7 @@ public AdditionalLightsShadowCasterPass(RenderPassEvent evt)
         public void Dispose()
         {
             m_AdditionalLightsShadowmapHandle?.Release();
+            m_EmptyAdditionalLightShadowmapTexture?.Release();
         }
 
         private int GetPunctualLightShadowSlicesCount(in LightType lightType)
@@ -850,6 +854,10 @@ bool SetupForEmptyRendering(ref RenderingData renderingData)
             m_CreateEmptyShadowmap = true;
             useNativeRenderPass = false;
 
+            // Required for scene view camera(URP renderer not initialized)
+            if(ShadowUtils.ShadowRTReAllocateIfNeeded(ref m_EmptyAdditionalLightShadowmapTexture, 1, 1, k_ShadowmapBufferBits, name: "_EmptyAdditionalLightShadowmapTexture"))
+                m_EmptyShadowmapNeedsClear = true;
+
             // initialize _AdditionalShadowParams
             for (int i = 0; i < m_AdditionalLightIndexToShadowParams.Length; ++i)
                 m_AdditionalLightIndexToShadowParams[i] = c_DefaultShadowParams;
@@ -860,13 +868,18 @@ bool SetupForEmptyRendering(ref RenderingData renderingData)
         /// <inheritdoc/>
         public override void Configure(CommandBuffer cmd, RenderTextureDescriptor cameraTextureDescriptor)
         {
-            
-            if (m_CreateEmptyShadowmap)
+            if (m_CreateEmptyShadowmap && !m_EmptyShadowmapNeedsClear)
             {
                 // Reset pass RTs to null
                 ResetTarget();
                 return;
             }
+            if (m_CreateEmptyShadowmap)
+            {
+                ConfigureTarget(m_EmptyAdditionalLightShadowmapTexture);
+                m_EmptyShadowmapNeedsClear = false;
+            }
+            else
                 ConfigureTarget(m_AdditionalLightsShadowmapHandle);
 
             ConfigureClear(ClearFlag.All, Color.black);

Packages/com.unity.render-pipelines.universal/Runtime/Passes/MainLightShadowCasterPass.cs

@@ -43,6 +43,7 @@ private static class MainLightShadowConstantBuffer
         Vector4[] m_CascadeSplitDistances;
 
         bool m_CreateEmptyShadowmap;
+        private bool m_EmptyShadowmapNeedsClear = false;
 
         int renderTargetWidth;
         int renderTargetHeight;
@@ -76,7 +77,8 @@ public MainLightShadowCasterPass(RenderPassEvent evt)
 
             m_MainLightShadowmapID = Shader.PropertyToID(k_MainLightShadowMapTextureName);
 
-            m_EmptyMainLightShadowmapTexture = RTHandles.Alloc(Texture2D.blackTexture);
+            m_EmptyMainLightShadowmapTexture = ShadowUtils.AllocShadowRT(1, 1, k_ShadowmapBufferBits, 1, 0, name: "_EmptyLightShadowmapTexture");
+            m_EmptyShadowmapNeedsClear = true;
         }
 
         /// <summary>
@@ -163,22 +165,31 @@ bool SetupForEmptyRendering(ref RenderingData renderingData)
 
             m_CreateEmptyShadowmap = true;
             useNativeRenderPass = false;
-            ShadowUtils.ShadowRTReAllocateIfNeeded(ref m_EmptyMainLightShadowmapTexture, k_EmptyShadowMapDimensions, k_EmptyShadowMapDimensions, k_ShadowmapBufferBits, name: k_EmptyMainLightShadowMapTextureName);
+
+            // Required for scene view camera(URP renderer not initialized)
+            if(ShadowUtils.ShadowRTReAllocateIfNeeded(ref m_EmptyMainLightShadowmapTexture, 1, 1, k_ShadowmapBufferBits, name: "_EmptyLightShadowmapTexture"))
+                m_EmptyShadowmapNeedsClear = true;
 
             return true;
         }
 
         /// <inheritdoc />
         public override void Configure(CommandBuffer cmd, RenderTextureDescriptor cameraTextureDescriptor)
         {
-            
-            if (m_CreateEmptyShadowmap)
+            if (m_CreateEmptyShadowmap && !m_EmptyShadowmapNeedsClear)
             {
                 // Reset pass RTs to null
                 ResetTarget();
                 return;
             }
+            if (m_CreateEmptyShadowmap)
+            {
+                ConfigureTarget(m_EmptyMainLightShadowmapTexture);
+                m_EmptyShadowmapNeedsClear = false;
+            }
+            else
                 ConfigureTarget(m_MainLightShadowmapTexture);
+
             ConfigureClear(ClearFlag.All, Color.black);
         }