Added two tests

Author: belgaard

Packages/com.unity.render-pipelines.core/Runtime/Lighting/ProbeVolume/ProbeReferenceVolume.ReflProbeNormalization.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using Unity.Collections;
 #if UNITY_EDITOR
@@ -25,6 +26,7 @@ public class AdditionalGIBakeRequestsManager
         public static AdditionalGIBakeRequestsManager instance { get { return s_Instance; } }
 
         const float kInvalidSH = 1f;
+        const float kInvalidValidity = 1f;
         const float kValidSHThresh = 0.33f;
 
         private static Dictionary<int, SphericalHarmonicsL2> m_SHCoefficients = new Dictionary<int, SphericalHarmonicsL2>();
@@ -64,6 +66,7 @@ public void DequeueRequest(int probeInstanceID)
         /// <param name ="sh"> The output SH coefficients that have been computed.</param>
         /// <param name ="pos"> The position for which the computed SH coefficients are valid.</param>
         /// <returns>Whether the request for light probe rendering has been fulfilled and sh is valid.</returns>
+        [Obsolete("Use RetrieveProbe instead.", false)]
         public bool RetrieveProbeSH(int probeInstanceID, out SphericalHarmonicsL2 sh, out Vector3 pos)
         {
             if (m_SHCoefficients.ContainsKey(probeInstanceID))
@@ -78,6 +81,32 @@ public bool RetrieveProbeSH(int probeInstanceID, out SphericalHarmonicsL2 sh, ou
             return false;
         }
 
+        /// <summary>
+        /// Retrieve the result of a capture request, it will return false if the request ID is invalid.
+        /// </summary>
+        /// <param name ="probeInstanceID"> The instance ID of the probe doing the request.</param>
+        /// <param name ="pos"> The position for which the computed SH coefficients are valid.</param>
+        /// <param name ="sh"> The output SH coefficients that have been computed.</param>
+        /// <param name ="validity"> The output validity that has been computed.</param>
+        /// <returns>True if the request ID is valid.</returns>
+        public bool RetrieveProbe(EntityId probeInstanceID, out Vector3 pos, out SphericalHarmonicsL2 sh, out float validity)
+        {
+            if (m_SHCoefficients.ContainsKey(probeInstanceID))
+            {
+                sh = m_SHCoefficients[probeInstanceID];
+                pos = m_RequestPositions[probeInstanceID];
+                validity = m_SHValidity[probeInstanceID];
+
+                return true;
+            }
+
+            sh = new SphericalHarmonicsL2();
+            pos = Vector3.negativeInfinity;
+            validity = float.NegativeInfinity;
+
+            return false;
+        }
+
         static internal bool GetPositionForRequest(int probeInstanceID, out Vector3 pos)
         {
             if (m_SHCoefficients.ContainsKey(probeInstanceID))

Packages/com.unity.render-pipelines.high-definition/Runtime/Lighting/Reflection/HDProbe.cs

@@ -791,7 +791,9 @@ public virtual void PrepareCulling() { }
         internal void TryUpdateLuminanceSHL2ForNormalization()
         {
 #if UNITY_EDITOR
-            m_HasValidSHForNormalization = AdditionalGIBakeRequestsManager.instance.RetrieveProbeSH(GetInstanceID(), out m_SHForNormalization, out m_SHValidForCapturePosition);
+            const float kValidSHThresh = 0.33f; // This threshold is used to make the code below functionally equivalent to the obsolete RetrieveProbeSH. 
+            m_HasValidSHForNormalization = AdditionalGIBakeRequestsManager.instance.RetrieveProbe(GetEntityId(), out m_SHValidForCapturePosition, out m_SHForNormalization, out float validity);
+            m_HasValidSHForNormalization = m_HasValidSHForNormalization && validity < kValidSHThresh;
             if (m_HasValidSHForNormalization)
                 m_SHValidForSourcePosition = transform.position;
 #endif