Skip to content

Commit ff5087a

Browse files
joelprydeEvergreen
authored andcommitted
[6.4] Deprecate FindObjectsSortMode and Object.FindObject* methods that depend on InstanceID sort order.
1 parent becb48f commit ff5087a

File tree

40 files changed

+85
-25
lines changed

40 files changed

+85
-25
lines changed

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.LightTransport.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,7 @@ static void UpdateLightStatus()
668668
var sceneLights = new Dictionary<Scene, List<Light>>();
669669

670670
// Modify each baked light, take note of which scenes they belong to.
671-
var allLights = Object.FindObjectsByType<Light>(FindObjectsSortMode.None);
671+
var allLights = Object.FindObjectsByType<Light>();
672672
foreach (var light in allLights)
673673
{
674674
if (light.lightmapBakeType != LightmapBakeType.Realtime)

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.Placement.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,9 @@ internal static List<ProbeVolumePerSceneData> GetPerSceneDataList()
7373

7474
internal static List<ProbeVolume> GetProbeVolumeList()
7575
{
76+
#pragma warning disable CS0618 // Type or member is obsolete
7677
var fullPvList = GameObject.FindObjectsByType<ProbeVolume>(FindObjectsSortMode.InstanceID);
78+
#pragma warning restore CS0618 // Type or member is obsolete
7779
List<ProbeVolume> usedPVList;
7880

7981
if (isBakingSceneSubset)

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -746,7 +746,9 @@ static internal void Clear()
746746
if (activeSet != null)
747747
activeSet.Clear();
748748

749+
#pragma warning disable CS0618 // Type or member is obsolete
749750
var probeVolumes = GameObject.FindObjectsByType<ProbeVolume>(FindObjectsSortMode.InstanceID);
751+
#pragma warning restore CS0618 // Type or member is obsolete
750752
foreach (var probeVolume in probeVolumes)
751753
probeVolume.OnLightingDataAssetCleared();
752754
}
@@ -879,7 +881,9 @@ static void CellCountInDirections(out Vector3Int minCellPositionXYZ, out Vector3
879881
static TouchupVolumeWithBoundsList GetAdjustementVolumes()
880882
{
881883
// This is slow, but we should have very little amount of touchup volumes.
884+
#pragma warning disable CS0618 // Type or member is obsolete
882885
var touchupVolumes = Object.FindObjectsByType<ProbeAdjustmentVolume>(FindObjectsSortMode.InstanceID);
886+
#pragma warning restore CS0618 // Type or member is obsolete
883887

884888
var touchupVolumesAndBounds = new TouchupVolumeWithBoundsList(touchupVolumes.Length);
885889
foreach (var touchup in touchupVolumes)

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeSubdivisionContext.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ static void UpdateRealtimeSubdivisionDebug()
4242

4343
if (Time.realtimeSinceStartupAsDouble - s_LastSubdivisionTime > debugDisplay.subdivisionDelayInSeconds)
4444
{
45+
#pragma warning disable CS0618 // Type or member is obsolete
4546
var probeVolume = GameObject.FindFirstObjectByType<ProbeVolume>();
47+
#pragma warning restore CS0618 // Type or member is obsolete
4648
if (probeVolume == null || !probeVolume.isActiveAndEnabled)
4749
return;
4850

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeLightingTab.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1216,7 +1216,9 @@ internal class ProbeVolumeOverlay : Overlay, ITransientOverlay
12161216
{
12171217
if (ProbeReferenceVolume.instance.probeVolumeDebug.realtimeSubdivision)
12181218
{
1219+
#pragma warning disable CS0618 // Type or member is obsolete
12191220
var probeVolume = GameObject.FindFirstObjectByType<ProbeVolume>();
1221+
#pragma warning restore CS0618 // Type or member is obsolete
12201222
if (probeVolume != null && probeVolume.isActiveAndEnabled)
12211223
{
12221224
var profile = ProbeVolumeBakingSet.GetBakingSetForScene(probeVolume.gameObject.scene);

Packages/com.unity.render-pipelines.core/Runtime/Debugging/DebugManager.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,9 @@ void EnsurePersistentCanvas()
227227
{
228228
if (m_RootUIPersistentCanvas == null)
229229
{
230+
#pragma warning disable CS0618 // Type or member is obsolete
230231
var uiManager = UnityObject.FindFirstObjectByType<DebugUIHandlerPersistentCanvas>();
232+
#pragma warning restore CS0618 // Type or member is obsolete
231233

232234
if (uiManager == null)
233235
{

Packages/com.unity.render-pipelines.core/Runtime/Debugging/DebugUpdater.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ internal static void HandleInternalEventSystemComponents(bool uiEnabled)
8080

8181
void EnsureExactlyOneEventSystem()
8282
{
83-
var eventSystems = FindObjectsByType<EventSystem>(FindObjectsSortMode.None);
83+
var eventSystems = FindObjectsByType<EventSystem>();
8484
var debugEventSystem = GetComponent<EventSystem>();
8585

8686
if (eventSystems.Length > 1 && debugEventSystem != null)

Packages/com.unity.render-pipelines.core/Runtime/Lighting/ProbeVolume/ProbeVolumeBakingSet.Editor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ static void InflateBound(ref Bounds bounds, ProbeVolume pv)
525525

526526
internal void UpdateSceneBounds(Scene scene, string sceneGUID, bool onSceneSave)
527527
{
528-
var volumes = FindObjectsByType<ProbeVolume>(FindObjectsSortMode.None);
528+
var volumes = FindObjectsByType<ProbeVolume>();
529529
float prevBrickSize = ProbeReferenceVolume.instance.MinBrickSize();
530530
int prevMaxSubdiv = ProbeReferenceVolume.instance.GetMaxSubdivision();
531531
Vector3 prevOffset = ProbeReferenceVolume.instance.ProbeOffset();

Packages/com.unity.render-pipelines.core/Runtime/Lighting/ProbeVolume/ProbeVolumeGIContributor.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,9 @@ void PushTerrain(Terrain terrain)
196196
}
197197
else
198198
{
199+
#pragma warning disable CS0618 // Type or member is obsolete
199200
var renderers = Object.FindObjectsByType<Renderer>(FindObjectsSortMode.InstanceID);
201+
#pragma warning restore CS0618 // Type or member is obsolete
200202
Profiling.Profiler.BeginSample($"Find Renderers ({renderers.Length})");
201203
foreach (var renderer in renderers)
202204
{
@@ -205,7 +207,9 @@ void PushTerrain(Terrain terrain)
205207
}
206208
Profiling.Profiler.EndSample();
207209

210+
#pragma warning disable CS0618 // Type or member is obsolete
208211
var terrains = Object.FindObjectsByType<Terrain>(FindObjectsSortMode.InstanceID);
212+
#pragma warning restore CS0618 // Type or member is obsolete
209213
Profiling.Profiler.BeginSample($"Find Terrains ({terrains.Length})");
210214
foreach (var terrain in terrains)
211215
{

Packages/com.unity.render-pipelines.core/Runtime/PathTracing/PathTracingContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ public void Update(CommandBuffer cmd, PathTracingSettings settings)
186186
if (settings.lightPickingMethod == LightPickingMethod.Regir ||
187187
settings.lightPickingMethod == LightPickingMethod.LightGrid)
188188
{
189-
var sceneRenderers = Object.FindObjectsByType<Renderer>(FindObjectsSortMode.None);
189+
var sceneRenderers = Object.FindObjectsByType<Renderer>();
190190
foreach (Renderer r in sceneRenderers)
191191
sceneBounds.Encapsulate(r.bounds);
192192
}

0 commit comments

Comments
 (0)