[HDRP] Opening the first room of HDRP Template#8156
Merged
Conversation
JMargevics
approved these changes
Jul 23, 2025
Contributor
JMargevics
left a comment
There was a problem hiding this comment.
Hello! Looks like reflection probe from the dome interior is leaking into the pier and causing some tiled artifacts.
Otherwise looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
After discussing with Mathieu Muller, we had the idea of opening the main room to be able to see more the "recent" environment effects / features. (Water, Cloud Layer, Volumetric Clouds, Atmospheric Scattering, Volumetric Fog).
To be able to do that, With the help of @ValentinHume, the door on the other side has been duplicated to be able to access à small concrete pier.
In addition to that, there's a few things that has been done to the template as well:
And lighting have been rebaked.
Testing status
Opened the template with Unity 6.0, 6.1, 6.2, 6.3 to make sure nothing was broken.
Comments to reviewers
I know there's graphic tests with this project so I need to probably updated those as well.
We're open to suggestions if needed.