Skip to content

[PPV2] Update platforms support#8161

Merged
JanBorupJakobsen merged 5 commits into
masterfrom
ppv2/platforms-update
Jun 10, 2025
Merged

[PPV2] Update platforms support#8161
JanBorupJakobsen merged 5 commits into
masterfrom
ppv2/platforms-update

Conversation

@Wilfrid-Unity

@Wilfrid-Unity Wilfrid-Unity commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Purpose of this PR

This PR adds PPV2 support for Shader define of upcoming platform.


Testing status

UTJ QA team verified these PPV2 package changes as part of validation of Unity version used by pre-launch titles, using test project "Shinai" (see report here ).


Comments to reviewers

Landing of changes approved in this thread
This is part of worked tracked by these tickets: PLAT-13976, PLAT-13939

@BenGraterUnity BenGraterUnity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wilfrid-Unity Thanks for putting this together!

Looks good, although I'm not sure if/how I am able to test this currently. I have provided a couple minor comments.

Could you please expand the PR description on how specifically this was tested in editor and device?
Also, maybe just scan the package documentation to make sure there's nothing that would need updating there (probably not).

Comment thread com.unity.postprocessing/package.json Outdated
Comment thread com.unity.postprocessing/PostProcessing/Shaders/StdLib.hlsl Outdated
Comment thread com.unity.postprocessing/CHANGELOG.md Outdated
Wilfrid-Unity and others added 3 commits June 6, 2025 12:43
Co-authored-by: Ben Grater <87393999+BenGraterUnity@users.noreply.github.com>
Co-authored-by: Ben Grater <87393999+BenGraterUnity@users.noreply.github.com>
@Wilfrid-Unity

Copy link
Copy Markdown
Contributor Author

I have provided a couple minor comments.

Could you please expand the PR description on how specifically this was tested in editor and device?
Also, maybe just scan the package documentation to make sure there's nothing that would need updating there (probably not).

Thanks @BenGraterUnity, I have addressed your comments in commits 6cabdca..d74e354
I checked the package documentation and spotted nothing platform-specific.
I also added info in the PR about the testing these changes underwent ; let me know if you want more details.

@BenGraterUnity BenGraterUnity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, everything resolved and looks good. Thank you! 👍

@BenGraterUnity

Copy link
Copy Markdown
Contributor

@theopnv Could you merge this please?

@JanBorupJakobsen JanBorupJakobsen requested a review from a team as a code owner June 10, 2025 12:23
@JanBorupJakobsen JanBorupJakobsen merged commit b81f05b into master Jun 10, 2025
3 checks passed
@BenGraterUnity BenGraterUnity deleted the ppv2/platforms-update branch June 12, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants