FIX: Fixed inconsistent suppression behaviour between wasPressedThisFrame, wasPerformedThisFrame, wasReleasedThisFrame, wasCompletedThisFrame.

Author: ekcoh

Packages/com.unity.inputsystem/CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Fixed
 
 - Fixed `InputEventPtr.handled` not preventing actions from triggering when switching devices. The default event handled policy has been changed from `SuppressStateUpdates` (now deprecated) to `SuppressActionEventNotifications`, which keeps device state synchronized while suppressing action callbacks for handled events. [ISXB-1097](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1097)
+- Fixed `InputAction.WasReleasedThisFrame()`, `WasReleasedThisDynamicUpdate()`, `WasCompletedThisFrame()`, and `WasCompletedThisDynamicUpdate()` not respecting event suppression, making them inconsistent with `WasPressedThisFrame()` and `WasPerformedThisFrame()`. [ISXB-1097](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1097)
 - Fixed a `NullReferenceException` thrown when removing all action maps [UUM-137116](https://jira.unity3d.com/browse/UUM-137116)
 - Simplified default setting messaging by consolidating repetitive messages into a single HelpBox.
 - Fixed a `NullPointerReferenceException` thrown in `InputManagerStateMonitors.FireStateChangeNotifications` logging by adding validation [UUM-136095].

Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputAction.cs

@@ -1300,7 +1300,7 @@ public unsafe bool WasPressedThisFrame()
         public unsafe bool WasPressedThisDynamicUpdate()
         {
             var state = GetOrCreateActionMap().m_State;
-            if (state != null)
+            if (state != null && !state.IsSuppressed)
             {
                 var actionStatePtr = &state.actionStates[m_ActionIndexInState];
                 return actionStatePtr->framePressed == ExpectedFrame();
@@ -1350,7 +1350,7 @@ public unsafe bool WasPressedThisDynamicUpdate()
         public unsafe bool WasReleasedThisFrame()
         {
             var state = GetOrCreateActionMap().m_State;
-            if (state != null)
+            if (state != null && !state.IsSuppressed)
             {
                 var actionStatePtr = &state.actionStates[m_ActionIndexInState];
                 var currentUpdateStep = InputUpdate.s_UpdateStepCount;
@@ -1391,7 +1391,7 @@ public unsafe bool WasReleasedThisFrame()
         public unsafe bool WasReleasedThisDynamicUpdate()
         {
             var state = GetOrCreateActionMap().m_State;
-            if (state != null)
+            if (state != null && !state.IsSuppressed)
             {
                 var actionStatePtr = &state.actionStates[m_ActionIndexInState];
                 return actionStatePtr->frameReleased == ExpectedFrame();
@@ -1490,7 +1490,7 @@ public unsafe bool WasPerformedThisDynamicUpdate()
         {
             var state = GetOrCreateActionMap().m_State;
 
-            if (state != null)
+            if (state != null && !state.IsSuppressed)
             {
                 var actionStatePtr = &state.actionStates[m_ActionIndexInState];
                 return actionStatePtr->framePerformed == ExpectedFrame();
@@ -1571,7 +1571,7 @@ public unsafe bool WasCompletedThisFrame()
         {
             var state = GetOrCreateActionMap().m_State;
 
-            if (state != null)
+            if (state != null && !state.IsSuppressed)
             {
                 var actionStatePtr = &state.actionStates[m_ActionIndexInState];
                 var currentUpdateStep = InputUpdate.s_UpdateStepCount;
@@ -1612,7 +1612,7 @@ public unsafe bool WasCompletedThisDynamicUpdate()
         {
             var state = GetOrCreateActionMap().m_State;
 
-            if (state != null)
+            if (state != null && !state.IsSuppressed)
             {
                 var actionStatePtr = &state.actionStates[m_ActionIndexInState];
                 return actionStatePtr->frameCompleted == ExpectedFrame();