Commit e3a0cb7
Address u-pr review feedback for UUM-141423
- Collapse the composite-part scan into a single loop. The original two-pass
scan computed lastPartIndex but did not use it for outer-loop advancement,
so merging the bounds check into the for-loop condition eliminates the
redundant first pass without changing behaviour.
- Reword the inline comment to reference the index-based GetBindingDisplayString
overload by name instead of by line number, which goes stale as the file
is edited.
- Add Actions_WhenGettingDisplayTextForBindingsOnAction_MixedGroupCompositeIsRenderedAtomicallyWhenAnyPartMatchesBindingMask
covering a mixed-group 1DAxis composite (Keyboard + Mouse parts) under both
MaskByGroup("Keyboard") and MaskByGroup("Mouse"). Both masks must render the
whole composite ("A/Left Button"), exercising the atomic-promotion claim.
Co-authored-by: Cursor <cursoragent@cursor.com>1 parent 4769538 commit e3a0cb7
2 files changed
Lines changed: 21 additions & 7 deletions
File tree
- Assets/Tests/InputSystem
- Packages/com.unity.inputsystem/InputSystem/Runtime/Actions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9253 | 9253 | | |
9254 | 9254 | | |
9255 | 9255 | | |
| 9256 | + | |
| 9257 | + | |
| 9258 | + | |
| 9259 | + | |
| 9260 | + | |
| 9261 | + | |
| 9262 | + | |
| 9263 | + | |
| 9264 | + | |
| 9265 | + | |
| 9266 | + | |
| 9267 | + | |
| 9268 | + | |
| 9269 | + | |
| 9270 | + | |
| 9271 | + | |
| 9272 | + | |
9256 | 9273 | | |
9257 | 9274 | | |
9258 | 9275 | | |
| |||
Lines changed: 4 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
323 | 323 | | |
324 | 324 | | |
325 | 325 | | |
326 | | - | |
327 | | - | |
328 | | - | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
329 | 329 | | |
330 | 330 | | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | 331 | | |
335 | | - | |
| 332 | + | |
336 | 333 | | |
337 | 334 | | |
338 | 335 | | |
| |||
0 commit comments