Conversation
lilisha-unity
left a comment
There was a problem hiding this comment.
I did my first pass on the PR. Please fix the note formatting and replace the placeholder image alt text with something more descriptive. Also, there are quite a few sentences written in passive voice—please rewrite them in active voice where appropriate. You can refer to the Unity style guide for reference: https://docs-style-guide.unity.com/style/use-active-voice.
…sors.md Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
…sors.md Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
…sors.md Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2171 +/- ##
===========================================
- Coverage 67.81% 67.78% -0.03%
===========================================
Files 367 367
Lines 53513 53513
===========================================
- Hits 36288 36276 -12
- Misses 17225 17237 +12
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lilisha-unity
left a comment
There was a problem hiding this comment.
Finished my review with some suggestions.
Co-authored-by: lilisha-unity <94024889+lilisha-unity@users.noreply.github.com>
…es/InputSystem into docs-processors
ekcoh
left a comment
There was a problem hiding this comment.
Looks good to me, added some minor comments
|
|
||
| #### Example: Racing game speend control | ||
|
|
||
| In a case where the player is not supposed to fall below a certain base speed, but also cannot exceed a certain maximum speed, the Clamp Processor is the one you may want to use. |
There was a problem hiding this comment.
Generally, IMO this to be game-logic and not input logic, but its fine as-is to show as example.
|
Looks like there is some CI issues that needs attention |
jfreire-unity
left a comment
There was a problem hiding this comment.
Thanks, an important improvement for our docs!
I added some minor suggestions.
Mostly nitpicks around using "Processors" and "processors". I probably didn't catch them all, but it would be good to always use the same.
| "invert,normalize(min=0,max=10)" | ||
| ``` | ||
|
|
||
| ## Choose the right Processor |
| The [Scale Processor](ProcessorTypes.md#scale) multiplies the input value by a given factor X. This applies to float values as well as vectors, where each axis is multiplied by the corresponding factor specified for that axis. | ||
| This allows you to assign weight to input values, which can, for example, make a particular type of control easier to use. | ||
|
|
||
| #### Example: Horizontally aligned Camera |
There was a problem hiding this comment.
I don't think it makes sense to add now but I feel it can be mentioned. This example would be a great shout out to another package users might not be aware of, such as Cinemachine!
Co-authored-by: João Freire <joao.freire@unity3d.com>
Co-authored-by: João Freire <joao.freire@unity3d.com>
Co-authored-by: João Freire <joao.freire@unity3d.com>
Co-authored-by: João Freire <joao.freire@unity3d.com>
Co-authored-by: João Freire <joao.freire@unity3d.com>
Description
This adds more documentation on how to use processors.
Testing status & QA
No testing
Overall Product Risks
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: