CHANGE: Rework Core Platforms Menu scene used for internal testing#2405
CHANGE: Rework Core Platforms Menu scene used for internal testing#2405Pauliusd01 wants to merge 10 commits intodevelopfrom
Conversation
Pauliusd01
changed the title
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2405 +/- ##
===========================================
+ Coverage 77.92% 78.13% +0.21%
===========================================
Files 482 483 +1
Lines 97755 98769 +1014
===========================================
+ Hits 76175 77175 +1000
- Misses 21580 21594 +14 Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@u-pr can you check that all issues were resolved? Note that some had to be skipped such as: |
|
I've reviewed the latest changes against the feedback provided in the comments and your notes on skipped items. It appears that all identified issues have been addressed or clarified: ✅ Resolved Issues
⏭️ Skipped (As per your notes)
🤖 Helpful? 👍/👎 |
|
Think I found an issue: Run the sample
Clicking the top-left sample takes me to that sample scene but "Menu" button in top-left corner doesn't take me back. It looks like some dialog is shown but "behind the current UI" where the dialog and the sample UI is fighting so I cannot click the dialog. Or is the design intended to be so that you need to hold mouse button down after pressing Menu, then move to dialog with button down and then click your choice? In that case it works as expected. |
ekcoh
left a comment
ekcoh
left a comment
There was a problem hiding this comment.
Nice, added a suggestion since I didn't like the clashing overlays due to no camera being active. Apart from that, looks much better and setting things up programatically had a great impact on reducing size (rows removed is great).
Added a note on unexpected behaviour (having to hold mouse button while navigating overlay instead of toggle)
MorganHoarau
left a comment
MorganHoarau
left a comment
There was a problem hiding this comment.
Minor change requested.
Not a fan of building entire uGUI from script, but good enough for internal testing.
Looks great, but haven't tested locally.
3 participants
Description
Reworks the menu scene visuals, adds a search bar, adds the feature to auto fill the list with relevant scenes and improves gamepad controls. (You need to hold Start to go back to the main menu using the gamepad)
Testing status & QA
Run the menu scene and try loading the samples/qa scenes in playmode and build
Overall Product Risks
Comments to reviewers
N/A
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.