FIX: Fixing TMP text wrap API broke compilation on Unity 2022.3 (TMP 3.0.7) - #2445
Closed
josepmariapujol-unity wants to merge 1 commit into
Closed
FIX: Fixing TMP text wrap API broke compilation on Unity 2022.3 (TMP 3.0.7)#2445josepmariapujol-unity wants to merge 1 commit into
josepmariapujol-unity wants to merge 1 commit into
Conversation
The 'textWrappingMode' enum property is only available in the TextMeshPro shipping with Unity 6+; on older versions we fall back to the 'enableWordWrapping' boolean.
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2445 +/- ##
============================================
+ Coverage 58.58% 78.93% +20.35%
============================================
Files 738 767 +29
Lines 135831 140714 +4883
============================================
+ Hits 79570 111077 +31507
+ Misses 56261 29637 -26624 Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pauliusd01
requested changes
Jul 15, 2026
Pauliusd01
left a comment
Collaborator
There was a problem hiding this comment.
22.3 is no longer supported so I don't see the point of this change unless it is broken in newer ones too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 'textWrappingMode' enum property is only available in the TextMeshPro shipping with Unity 6+; on older versions we fall back to the 'enableWordWrapping' boolean.
Testing status & QA
Manually compiled editor
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.