-
Notifications
You must be signed in to change notification settings - Fork 339
CHANGE: Bump version to 1.20.1 #2455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,70 +3,70 @@ | |
| { | ||
| "ValidationTest": "API Validation", | ||
| "ExceptionMessage": "Breaking changes require a new major version.", | ||
| "PackageVersion": "1.20.0", | ||
| "PackageVersion": "1.20.1", | ||
| "__comments": "starting from 2022.3 ugui is not added to the project by default. We have some APIs that are conditional on ugui being present, so the API Validation thinks we are breaking API, but that is not the case." | ||
| }, | ||
| { | ||
| "ValidationTest": "API Validation", | ||
| "ExceptionMessage": "New assembly \"Unity.InputSystem.TestFramework\" may only be added in a new minor or major version.", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| }, | ||
| { | ||
| "ValidationTest": "API Validation", | ||
| "ExceptionMessage": "Additions require a new minor or major version.", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to upgrade this here to 1.20.1 ? It's the only concern I have, since we might lose visibility in changes we do while in 1.20.1, since we are ignoring it. If you don't bump this, what happens?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried and it was still failing like the exception comments suggest. I believe all of them are still needed
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I meant all of these bumps with my previous comment |
||
| }, | ||
| { | ||
| "ValidationTest": "NDA Keyword Validation", | ||
| "ExceptionMessage": "File 'InputSystem/Runtime/Plugins/iOS/IOSGameController.cs' contains keyword pattern '(?<!(BuildTarget|BuildTargetGroup|BuildSettings|AddressablesPlatform|RuntimePlatform|TargetPlatform|OpCodes|GraphicsDeviceType))\\.switch\\W' which indicates it is specific to restricted targets '-Switch'. It must not be published", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| }, | ||
| { | ||
| "ValidationTest": "NDA Keyword Validation", | ||
| "ExceptionMessage": "using UnityEngine.InputSystem.Switch;", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| }, | ||
|
|
||
| { | ||
| "ValidationTest": "NDA Keyword Validation", | ||
| "ExceptionMessage": "File 'InputSystem/Runtime/Plugins/Switch/SwitchProController.cs' contains keyword pattern '(?<!(BuildTarget|BuildTargetGroup|BuildSettings|AddressablesPlatform|RuntimePlatform|TargetPlatform|OpCodes|GraphicsDeviceType))\\.switch\\W' which indicates it is specific to restricted targets '-Switch'. It must not be published", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| }, | ||
| { | ||
| "ValidationTest": "NDA Keyword Validation", | ||
| "ExceptionMessage": "File 'InputSystem/Runtime/Plugins/Switch/SwitchProControllerHID.cs' contains keyword pattern '(?<!(BuildTarget|BuildTargetGroup|BuildSettings|AddressablesPlatform|RuntimePlatform|TargetPlatform|OpCodes|GraphicsDeviceType))\\.switch\\W' which indicates it is specific to restricted targets '-Switch'. It must not be published", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| }, | ||
|
|
||
| { | ||
| "ValidationTest": "NDA Keyword Validation", | ||
| "ExceptionMessage": "namespace UnityEngine.InputSystem.Switch", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| }, | ||
| { | ||
| "ValidationTest": "NDA Keyword Validation", | ||
| "ExceptionMessage": "using UnityEngine.InputSystem.Switch.LowLevel;", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| }, | ||
| { | ||
| "ValidationTest": "NDA Keyword Validation", | ||
| "ExceptionMessage": "namespace UnityEngine.InputSystem.Switch.LowLevel", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| }, | ||
| { | ||
| "ValidationTest": "NDA Keyword Validation", | ||
| "ExceptionMessage": "File 'Documentation~/gamepads-s.md' contains keyword pattern '(?<!(BuildTarget|BuildTargetGroup|BuildSettings|AddressablesPlatform|RuntimePlatform|TargetPlatform|OpCodes|GraphicsDeviceType))\\.switch\\W' which indicates it is specific to restricted targets '-Switch'. It must not be published", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| }, | ||
| { | ||
| "ValidationTest": "NDA Keyword Validation", | ||
| "ExceptionMessage": "The Input System supports Switch Pro controllers on desktop computers with the [`SwitchProControllerHID`](xref:UnityEngine.InputSystem.Switch.SwitchProControllerHID) class, which implements basic gamepad functionality.", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| }, | ||
| { | ||
| "ValidationTest": "Assembly Definition Validation", | ||
| "ExceptionMessage": "For editor assemblies, 'Editor' should be present in the includePlatform section in: [{Package-Root}/InputSystem/Editor/Plugins/InputForUI/InputSystemForUI.Editor.asmdef]", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| } | ||
| ], | ||
| "WarningExceptions": [] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating this generic API-validation exemption to
1.20.1keeps it active for every future1.20.1build, because the entry is keyed only byPackageVersionplus the broad message"Additions require a new minor or major version."The similar"Breaking changes require a new major version."entry above has the same problem. That means any new API additions or breaks merged ondevelopbefore the next version bump will be silently exempted instead of failing validation, which defeats the semver guardrail for the whole1.20.1window. Please either drop these blanket exceptions when moving off the 1.20.0 release, or narrow them to the specific known false positives only.🤖 Helpful? 👍/👎